Skip to content

Bug fix: Each alarm gets its own notification rather than sharing a global one - #535

Closed
smugleafdev wants to merge 5 commits into
FossifyOrg:mainfrom
smugleafdev:main
Closed

smugleafdev wants to merge 5 commits into
FossifyOrg:mainfrom
smugleafdev:main

Conversation

@smugleafdev

@smugleafdev smugleafdev commented Nov 9, 2026 •

Copy link
Copy Markdown

Note regarding issue not yet in "help wanted"

I read the contribution guidelines, I can see that this will likely be closed without review because the issue I filled out in early September is still in "needs triage" and not "helped wanted". I made the changes and I'm going to be using my fork as this bug afflicts me literally every single weekday morning. I had the time to do this now, and may not find the time to do so again in the near future, and at least all anyone will need to do is just copy this.

Note 2: Include #469 alarm label fix

Simplified their code to be compatible with this PR

Type of change(s)

  • Bug fix
  • Feature / enhancement
  • Infrastructure / tooling (CI, build, deps, tests)
  • Documentation

What changed and why

There is one global alarm notification, meaning if there are two alarms close together, the latter cannot be dismissed before the alarm triggers. This stops using a single, global notification and instead creates a new one per upcoming alarm. Each notification's text is set to when the alarm is set to trigger.

Also modified the changes from #469 to be compatible with the new notifications.

Tests performed

Tested with varying alarms (a bunch one minute apart, several 15 minutes apart) on a Samsung Z Fold7.

Before & after preview

Screenshot taken while running the fork this PR is from:

ignoreImageMinify

No real before preview, just imagine a single notification.

And here's a screenshot after adding the alarm labels:

ignoreImageMinify

Closes the following issue(s)

Checklist

  • I read the contribution guidelines.
  • I manually tested my changes on device/emulator (if applicable).
  • I updated the "Unreleased" section in CHANGELOG.md (if applicable).
  • I have self-reviewed my pull request (no typos, formatting errors, etc.).
  • I understand every change in this pull request.

@fossifybot

fossifybot Bot commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

Fossify accepts code contributions only for open issues labeled help wanted. This pull request does not meet that requirement or one of the documented exceptions, so it is being closed without review. Please read the contribution guidelines before starting work.

@fossifybot fossifybot Bot closed this Nov 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing upcoming notification for alarms Upcoming Alarm Notification does not show Label

1 participant