Repository navigation
Bug fix: Each alarm gets its own notification rather than sharing a global one - #535
Closed
smugleafdev wants to merge 5 commits into
Closed
smugleafdev wants to merge 5 commits into
smugleafdev wants to merge 5 commits into
Conversation
Contributor
|
Fossify accepts code contributions only for open issues labeled |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note regarding issue not yet in "help wanted"
I read the contribution guidelines, I can see that this will likely be closed without review because the issue I filled out in early September is still in "needs triage" and not "helped wanted". I made the changes and I'm going to be using my fork as this bug afflicts me literally every single weekday morning. I had the time to do this now, and may not find the time to do so again in the near future, and at least all anyone will need to do is just copy this.
Note 2: Include #469 alarm label fix
Simplified their code to be compatible with this PR
Type of change(s)
What changed and why
There is one global alarm notification, meaning if there are two alarms close together, the latter cannot be dismissed before the alarm triggers. This stops using a single, global notification and instead creates a new one per upcoming alarm. Each notification's text is set to when the alarm is set to trigger.
Also modified the changes from #469 to be compatible with the new notifications.
Tests performed
Tested with varying alarms (a bunch one minute apart, several 15 minutes apart) on a Samsung Z Fold7.
Before & after preview
Screenshot taken while running the fork this PR is from:
No real before preview, just imagine a single notification.
And here's a screenshot after adding the alarm labels:
Closes the following issue(s)
Checklist
CHANGELOG.md(if applicable).