Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the decoder-only embedder (
finetune/embedder/decoder_only/base/load_model.py),save_merged_modelusestokenizerbefore it is created. Since 3bc1962 ("only modify vocab_size when necessary") thevocab_sizeupdate sits inside theemb.pthbranch, above the line that loads the tokenizer, so merging a LoRA run that saved its embeddings (added tokens) fails withNameError: name 'tokenizer' is not definedat the end of training (runner.pycalls it whensave_merged_lora_modelis set).This loads the tokenizer just before that branch and keeps the update conditional, as 3bc1962 intended. Nothing else changes; the ICL variant already loads the tokenizer first.
Found with
ruff check --select F821, which no longer reports it.