Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When dense embedder training disables in-batch negatives, the default local-scoring path still builds scores for every query against every passage and then selects each query's own passage group. For B queries and G passages per query, this materializes a B × (B × G) matrix although the objective uses only B × G entries.
Changes
The three built-in dense embedder models use their existing batched similarity operation to compute each query's own passage group directly. The abstract embedder's two-dimensional scoring contract stays unchanged. Explicit scoring callbacks and dense subclasses that override
compute_scoreretain the original path, so the optimization does not add a new shape requirement to custom models.This is separate from #1609, which corrects M3 local-target and ensemble layouts. This patch leaves those loss and M3 callback paths unchanged.
Validation
git diff --checkpass.