Conversation
Callable-shaped nodes now delegate to ExpressionResolver: the four call kinds (FuncCall, MethodCall, NullsafeMethodCall, StaticCall) go through resolve(); New_ and Attribute go through the new resolveConstructor(). Hover on an instance method call whose return type is static now late-binds to the receiver class, matching StaticCall. Deletes the per-kind helpers and the now-unreferenced MemberAccessDetector::resolveInstanceAccessClassName.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #477 +/- ##
============================================
- Coverage 99.50% 99.40% -0.11%
+ Complexity 1886 1875 -11
============================================
Files 132 132
Lines 4876 4838 -38
============================================
- Hits 4852 4809 -43
- Misses 24 29 +5 ☔ View full report in Codecov by Harness. |
Firehed
marked this pull request as ready for review
September 1, 2026 00:24
Owner
Author
|
Overriding CI: net project coverage drop due to removing covered lines. Diff still 100% which is more important. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Done