Skip to content

chore(ci): upgrade forge to 1.7.1 - #290

Merged
wjmelements merged 2 commits into
mainfrom
chore/forge-1.7.1-lint-ci
Jul 28, 2026
Merged

chore(ci): upgrade forge to 1.7.1#290
wjmelements merged 2 commits into
mainfrom
chore/forge-1.7.1-lint-ci

Conversation

@wjmelements

Copy link
Copy Markdown
Contributor

Updated forge from 1.3.5 to 1.7.1. Pulls fvm-solidity dep which also did this (filecoin-project/fvm-solidity#20). Ran forge fmt which had a behavioral change. Excluded newly failing lints except unwrapped-modifier-logic, which was easy to fix.

Assisted-by: Claude:claude-sonnet-4-6
@wjmelements
wjmelements requested a review from rvagg July 27, 2026 20:47
@FilOzzy FilOzzy added this to FOC Jul 27, 2026
@github-project-automation github-project-automation Bot moved this to 📌 Triage in FOC Jul 27, 2026
@rvagg

rvagg commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

@wjmelements there's also makefile.yml and publish-abis.yml which we've stuck on nightly for some reason and probably should change to be consistent.

Comment thread foundry.toml Outdated
Comment thread foundry.toml

@rvagg rvagg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving pending removal of the comment in foundry.toml and opening an issue to remove unsafe-typecast as a separate batch of work for someone

@github-project-automation github-project-automation Bot moved this from 📌 Triage to ✔️ Approved by reviewer in FOC Jul 28, 2026
Assisted-by: Claude:claude-sonnet-4-6
@wjmelements
wjmelements merged commit 2439b52 into main Jul 28, 2026
3 checks passed
@wjmelements
wjmelements deleted the chore/forge-1.7.1-lint-ci branch July 28, 2026 20:21
@github-project-automation github-project-automation Bot moved this from ✔️ Approved by reviewer to 🎉 Done in FOC Jul 28, 2026
@github-project-automation github-project-automation Bot moved this to 🎉 Done in PDP Jul 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🎉 Done
Status: 🎉 Done

Development

Successfully merging this pull request may close these issues.

3 participants