feat: emit PiecesScheduledForRemoval when scheduling piece deletions - #287
Open
nishant-uxs wants to merge 2 commits into
Open
feat: emit PiecesScheduledForRemoval when scheduling piece deletions#287nishant-uxs wants to merge 2 commits into
nishant-uxs wants to merge 2 commits into
Conversation
Make scheduled deletions observable to event-driven indexers before nextProvingPeriod processes removals.
wjmelements
reviewed
Jul 27, 2026
| scheduledRemovals[setId].push(pieceId); | ||
| } | ||
|
|
||
| emit PiecesScheduledForRemoval(setId, pieceIds); |
Contributor
There was a problem hiding this comment.
emit after listener instead of before, in case listener rejects
Author
|
Addressed in 8aba46b — emit now happens after the listener call, matching the other listener/emit sequences in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PiecesScheduledForRemoval(setId, pieceIds)fromschedulePieceDeletionsso indexers can observe scheduled removals immediately, without waiting forPiecesRemovedat the next proving boundary.IPDPEventsalongside the existing piece lifecycle events.Closes #281
Files Changed
src/interfaces/IPDPEvents.solsrc/PDPVerifier.soltest/PDPVerifier.t.solTesting Performed
forge build --via-irforge test --via-ir(187 passed)Known Limitations
piecesScheduledRemovebehavior; event is for log-driven consumers.Risk Assessment