Skip to content

fix: non-reverting upgrade announcement - #285

Open
wjmelements wants to merge 2 commits into
mainfrom
fix/no-revert-announcement
Open

fix: non-reverting upgrade announcement#285
wjmelements wants to merge 2 commits into
mainfrom
fix/no-revert-announcement

Conversation

@wjmelements

@wjmelements wjmelements commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Toward FilOzone/filecoin-services#505
Reviewer @rjan90
Duplicates FilOzone/filecoin-services#547

Changes

  • deprecate current announcement method
  • new announce upgrade plan method
  • share upgrade announcement logic between new and old method
  • update tools, docs

@wjmelements
wjmelements requested a review from rjan90 July 23, 2026 00:55
@FilOzzy FilOzzy added this to FOC Jul 23, 2026
@github-project-automation github-project-automation Bot moved this to 📌 Triage in FOC Jul 23, 2026
@wjmelements wjmelements moved this from 📌 Triage to 🔎 Awaiting review in FOC Jul 23, 2026
@rjan90 rjan90 added this to the M4.5: GA Fast Follows milestone Jul 24, 2026
@wjmelements wjmelements moved this to 🔎 Awaiting review in PDP Jul 26, 2026
@rjan90

rjan90 commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

I reviewed this and opened #289 as a stacked follow-up targeting this branch. It updates the rollout checklist to use the relative-delay flow after bootstrap, validates and records the observed on-chain afterEpoch, and retains the currently required v3.4.0 legacy bootstrap path. Removal of that temporary compatibility path is tracked in #288.

@wjmelements, could you review and merge #289 into fix/no-revert-announcement before merging this PR?

I am approving #285 at its current head, conditional on #289 landing first. If this repository dismisses stale approvals when the stacked commit lands, a fresh approval will be required on the combined head.

@rjan90 rjan90 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Solidity change and tests look good. Approving at the current head, with #289 to land into this branch before merge so the rollout checklist uses the relative-delay flow and retains the required v3.4.0 bootstrap path.

@github-project-automation github-project-automation Bot moved this from 🔎 Awaiting review to ✔️ Approved by reviewer in FOC Jul 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✔️ Approved by reviewer
Status: 🔎 Awaiting review

Development

Successfully merging this pull request may close these issues.

3 participants