Skip to content

ci: Update add tests for PHP > 8.4 in tests workflow - #1077

Open
Chris53897 wants to merge 1 commit into
FakerPHP:2.0from
Chris53897:patch-1
Open

Chris53897 wants to merge 1 commit into
FakerPHP:2.0from
Chris53897:patch-1

Conversation

@Chris53897

@Chris53897 Chris53897 commented Nov 18, 2026 •

Copy link
Copy Markdown

experimental can be changed later to 8.7

Looks good, only 3 types of deprecations.
600x: Constant MT_RAND_PHP is deprecated since 8.3, as it uses a biased non-standard variant of Mt19937
Implicitly marking parameter $xxx as nullable is deprecated
656x: Method ReflectionProperty::setAccessible() is deprecated since 8.5, as it has no effect since PHP 8.1

@bram-pkg

Copy link
Copy Markdown
Member

Would you mind adding a fix for the deprecation?

@Chris53897

Copy link
Copy Markdown
Author

yes, i will have a look

@Chris53897

Chris53897 commented Nov 18, 2026 •

Copy link
Copy Markdown
Author

PRs shoul be splitted.
Part 1: UserAgentTest

The other will have maybe bc breaks

@Chris53897

Copy link
Copy Markdown
Author

In a normal repo the MT_RAND_PHP is easy to fix.
But not in this case.
The solution suggested by claude it to change it to mt_srand((int) $seed, MT_RAND_MT19937); and recalc test and change tests.
As this effects userland code for all there tests, this is not a valid solution.

For the moment this error should be ignored in the ci in my point of view.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants