Repository navigation
ci: Update add tests for PHP > 8.4 in tests workflow - #1077
Open
Chris53897 wants to merge 1 commit into
Open
Chris53897 wants to merge 1 commit into
Chris53897 wants to merge 1 commit into
Conversation
Member
|
Would you mind adding a fix for the deprecation? |
Author
|
yes, i will have a look |
Author
|
PRs shoul be splitted. The other will have maybe bc breaks |
Author
|
In a normal repo the MT_RAND_PHP is easy to fix. For the moment this error should be ignored in the ci in my point of view. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
experimental can be changed later to 8.7
Looks good, only 3 types of deprecations.
600x: Constant MT_RAND_PHP is deprecated since 8.3, as it uses a biased non-standard variant of Mt19937
Implicitly marking parameter $xxx as nullable is deprecated
656x: Method ReflectionProperty::setAccessible() is deprecated since 8.5, as it has no effect since PHP 8.1