Add smallsize=1 to pick the smallest disk, the counterpart of largesize=1 - #175
Merged
Merged
Conversation
…ze=1 getHardDisk() already honors a largesize=1 kernel argument that picks the largest disk by capacity when no Host Primary Disk is set. A fleet whose target disk is always the smallest one, but sits at a different bus position on every machine, had no equivalent (fogproject #817). smallsize=1 sorts the same list the other way. Ties keep enumeration order, as before. tests/checks/primary-disk-dedup.sh gains the three automatic choices on a stub machine whose first disk is neither the largest nor the smallest. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0131h4axUaE3VJZphvKRdDby
This was referenced Sep 2, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For FOGProject/fogproject#817: with several disks at different bus positions per machine, how do you always deploy to the smallest one?
getHardDisk()already honors alargesize=1kernel argument that picks the largest disk by capacity when no Host Primary Disk is set. This addssmallsize=1, which sorts the same list the other way. Ties keep enumeration order, as before. Both go in Host Kernel Arguments, or on a group.tests/checks/primary-disk-dedup.shgains the three automatic choices (none, largest, smallest) on a stub machine whose first disk is neither the largest nor the smallest, so each case lands on a different device. The smallest case fails on the old code.Docs for both arguments to follow in fog-docs, since neither is documented today.
🤖 Generated with Claude Code
https://claude.ai/code/session_0131h4axUaE3VJZphvKRdDby