Send all four firmware fields with a registration (fogproject #198) - #171
Merged
Merged
Conversation
Both registration scripts sent the system UUID, and the auto path the system serial. FOG 1.6 now identifies a machine by four SMBIOS fields -- UUID, system serial, baseboard serial, chassis asset tag -- and its registration path (fogproject #1674) scores whatever arrives, so a machine whose NIC was replaced is recognized as its existing host instead of registering a duplicate. One field scores one point; sending all four is what makes the match unambiguous on hardware where the UUID is a placeholder. The values are read, lowercased and base64-encoded exactly as sysuuid already was, and are sent on the hostexists check as well as the register call, since the manual path stops at the check. doInventory() overwrites every one of these variables from dmidecode afterward, so nothing here reaches the inventory POST. A server that does not know the fields ignores them. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LVm9aM4BHJywMoh1eaJMpZ
mastacontrola
deleted the
feat/198-registration-sends-firmware-fields
branch
September 2, 2026 12:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to FOGProject/fogproject#1674.
Both registration scripts sent
sysuuid, andfog.auto.regalsosysserial. FOG 1.6 identifies a machine by four SMBIOS fields and its registration path now scores whatever arrives, so this sends all four onauto.register.phpand on the manual path'sman.hostexists.phpcheck (the manual flow stops at that check, so the attach has to be possible there).Read, lowercased and base64-encoded exactly as
sysuuidalready is.doInventory()overwrites every one of these variables from dmidecode afterward, so the inventory POST is unaffected. A server without the fields ignores them; the 1.6 server side accepts their absence, so the two can merge in either order.Test suite: 18 passed, 0 failed, golden unchanged.
🤖 Generated with Claude Code
https://claude.ai/code/session_01LVm9aM4BHJywMoh1eaJMpZ