Use US spelling in the enrollment report - #167
Merged
Merged
Conversation
The companion to fos#166 shipped 23 UK spellings of "enrolment", and the
test file carried it in its NAME. FOS's own identifiers have always been US
-- fog.enrollsb, sbEnrollDb, sbStageMok's callers, and the 'db'/'trusted'/
'mok' vocabulary the server stores -- so the prose disagreed with the code
around it.
tests/checks/secureboot-enrolment-report.sh
-> tests/checks/secureboot-enrollment-report.sh
Scoped to the lines fos#166 added. fog.enrollsb and secureboot-funcs.sh both
carry pre-existing "enrolment" in text written before this work, including
the reference to docs/adr/0009-secure-boot-enrolment-paths.md, and those are
left alone -- rewriting them is a separate pass, and the filename of an ADR
that other files reference is its own decision.
One user-visible string changes: the note printed when the record could not
be reached on the server. No behaviour change, and the words sbReport sends
('db', 'trusted', 'mok') are untouched, so it stays wire-compatible with
service/secureboot.report.php on any server.
Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to FOGProject/fogproject#1453.
#166 shipped 23 UK spellings of
enrolment, and the test file carried it in its name:FOS's own identifiers have always been US —
fog.enrollsb,sbEnrollDb, and thedb/trusted/mokvocabulary the server stores — so the prose was disagreeing with the code around it.Scoped to the lines #166 added
fog.enrollsbandsecureboot-funcs.shboth carry pre-existingenrolmentin text written before this work, including the reference todocs/adr/0009-secure-boot-enrolment-paths.md. Those are left alone: rewriting them is a separate pass, and renaming an ADR that other files reference is its own decision.That does leave a mixture inside those two files, deliberately.
No behavior change, and wire-compatible
The words
sbReportsends —db,trusted,mok— are untouched, so this stays compatible withservice/secureboot.report.phpon any server, old or new. One user-visible string changes: the note printed when the record could not be reached.sh tests/run-all.sh— 17 passed, 0 failed.🤖 Generated with Claude Code
https://claude.ai/code/session_01C2gFRQ3Khhx24FNYMZhW6N