Pin the plugins release that names its own reports - #1472
Merged
Conversation
fog-plugins v1.6.19 consumes REPORT_TITLE_DATA, added to core in #1470, so the eight bundled plugin reports label their own menu entries instead of the sidebar deriving "Ou Report" from a file name. The same release moves those reports from getList() to reportRows() and opts them into the "CSV (All)" full export added in #1467. The pin is the half that makes it reach a server: ADR 0009 has the installer download the release this constant names, so until it moves, an install still fetches v1.6.18 and the eight reports keep the labels and the one-page CSV they had. Shipped in this order deliberately -- core first, then the plugins release, then this -- because the reverse leaves those grids empty on a core with no reportRows() to feed them. https://github.com/FOGProject/fog-plugins/releases/tag/v1.6.19 Co-Authored-By: Claude <noreply@anthropic.com>
…ng and set version to 1.6.0-beta.4440 (Beta) for merge into working-1.6 (#1472)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps
FOG_PLUGINS_VERSIONtov1.6.19.Third and last step of the sequence #1470 opened:
REPORT_TITLE_DATAevent, andregisterReportTable()gainsfullExport. Merged.getList()toreportRows(), and opt into CSV (All). Merged and released.Why the pin is not a formality
ADR 0009 has
bin/fetch-plugins.shandlib/common/config.shread this constant to choose the release to download. Until it moves, a fresh install still pullsv1.6.18, so the eight reports keep the sidebar labelsucwords()derived from their file names — "Ou Report" opening a page headed "Export OUs" — and keep the one-page CSV that #1467 replaced everywhere else.Order
Deliberately last. The reverse order — plugins pinned before core carries the seam — leaves those grids empty:
sub=exportAllservesReportManagement::reportRows(), and a core predating #1467 has none.Downstream
None. No route class added or removed, so FogApi's hardcoded class list is unaffected.
Verification
tests/run-all.sh: 200 passed, 0 failed. Both phpstan passes clean.