chore: lint against BigInt literals#73
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Some runtimes we ship to (notably Hermes) do not support BigInt literal syntax (`1n`), even though they support `BigInt(1)`. We already have a downstream patch (`exodus-bytes-no-bigint-literal.diff`) rewriting such literals; this prevents new ones from sneaking in. Tests and benchmarks are exempt since they are not shipped. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
depends on #72
Summary
no-restricted-syntax: Literal[bigint]to.eslintrc.cjsso new BigInt literals(e.g.
1n) cannot land in shipped source.tests/**andbenchmarks/**, which aren't shipped and use literal fixtures freely.Why
Some runtimes we ship to (notably Hermes) don't parse BigInt literal syntax even though
they support
BigInt(n). The exodus-mobile patchset already rewrites such literals(https://github.com/ExodusMovement/exodus-mobile/blob/main/src/patches-prod/exodus-bytes-
no-bigint-literal.diff). This rule prevents new ones from sneaking in.
Notes
literal (
32nin base58.js); without it CI on this PR would be red.Test plan
pnpm run lintpasses locally1ninbase58.js→ lint errors with the configured message