chore(deps): take the orchestrator releases that survive a moving branch - #228
Merged
Merged
Conversation
3.0.0 to 3.0.2. 3.0.1 retries a single-commit release whose atomic push lost a race to the branch, which this workspace uses: before it, a commit landing on main between the job checking out and its push cost the whole run. 3.0.2 fixes the per-package strategy, which this workspace does not use, so it changes nothing here. Neither of 3.0.0 major predecessors needs anything of this repository. 2.0.0 requires Node 22.18 or later and bans non-erasable syntax in TypeScript config files; .tool-versions pins 26 and the config uses neither enum nor namespace. 3.0.0 stops a package marked private creating a GitHub Release, which this repository already adopted in c047d11 when it took 3.0.0 and removed the packagePlugins block that had been forcing that behaviour by hand.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves
@exadev/semantic-release-workspacefrom 3.0.0 to 3.0.2.3.0.1 is the one that matters here. It retries a
commitStrategy: 'single'release whose atomic push lost a race to the branch, which is the strategy this workspace runs. Before it, a commit landing on main between the job checking out and its push cost the entire run: documents.js lost two consecutive releases to exactly that in nine minutes once a merge queue started landing pull requests continuously. See ExaDev/semantic-release-workspace#38.3.0.2 fixes the
per-packagestrategy, where a branch moving mid-run could leave the workspace partly released with the run still reporting success (ExaDev/semantic-release-workspace#40). This repository does not use that strategy, so it changes nothing here.Both majors between 3.0.0 and here were already crossed
Nothing to do for either, but I checked rather than assumed:
ts/.tool-versionspinsnodejs 26, andts/release-workspace.config.tsuses neitherenumnornamespace.privatefrom creating a GitHub Release. This repository already adopted that inc047d11, the commit that took 3.0.0 and removed thepackagePluginsblock which had been forcing@semantic-release/githubonto the private packages by hand. So there is no behaviour change left to absorb.Bumped with the package manager, so the pin stays exact and the lockfile moved with it.