Skip to content

Remove useless try-catch in StringUtil joinList methods #6610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Smorki wants to merge 1 commit into from
+2 −10
Closed

Remove useless try-catch in StringUtil joinList methods #6610

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 2 additions & 10 deletions Essentials/src/main/java/com/earth2me/essentials/utils/StringUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,11 +60,7 @@ public static String joinList(final String seperator, final Object... list) {
if (each instanceof Collection) {
buf.append(joinList(seperator, ((Collection) each).toArray()));
} else {
try {
buf.append(each.toString());
} catch (final Exception e) {
buf.append(each.toString());
}
buf.append(each.toString());
}
}
return buf.toString();
Expand All @@ -84,11 +80,7 @@ public static String joinListSkip(final String seperator, final String skip, fin
if (each instanceof Collection) {
buf.append(joinListSkip(seperator, skip, ((Collection) each).toArray()));
} else {
try {
buf.append(each.toString());
} catch (final Exception e) {
buf.append(each.toString());
}
buf.append(each.toString());
}
}
return buf.toString();
Expand Down