[fix][report-converter] Honour trim-path-prefix in sarif export - #4987
Open
Sanjays2402 wants to merge 1 commit into
Open
[fix][report-converter] Honour trim-path-prefix in sarif export#4987Sanjays2402 wants to merge 1 commit into
Sanjays2402 wants to merge 1 commit into
Conversation
The sarif parser built artifactLocation URIs from report.file.original_path, which always holds the untrimmed path, so `CodeChecker parse --trim-path-prefix ... --export sarif` still emitted absolute paths. Use report.file.path instead, which returns the trimmed path once Report.trim_path_prefixes() has been called and the original path otherwise. This mirrors the fix made for the HTML export in Ericsson#4387. Added a regression test asserting both the primary result location and the code flow locations honour the trimmed prefix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4659
The sarif exporter built
artifactLocationURIs fromreport.file.original_path, which always holds the untrimmed path, soCodeChecker parse --trim-path-prefix ... --export sarifstill emitted absolute paths. Usingreport.file.pathreturns the trimmed path onceReport.trim_path_prefixes()has run and the original path otherwise — the same fix applied to the HTML export in #4387.Added a regression test covering both the primary result location and the code flow locations; it fails on master with
file:///home/user/project/src/main.cand passes with the change.