ecdh_hsmd: ensure HSM fd is blocking on setup#9155
Open
nGoline wants to merge 1 commit into
Open
Conversation
On macOS under load, socketpair fds sent via SCM_RIGHTS can have O_NONBLOCK set (from the sender's io_new_conn call in hsmd's pass_client_hsmfd). This causes wire_sync_read to return NULL with EAGAIN, killing connectd or channeld with "No hsmd ECDH response". The fix mirrors the "Don't trust subd to set it blocking" pattern already used in lightningd/subd.c:read_fds(): explicitly call io_fd_block(hsm_fd, true) in ecdh_hsmd_setup. Changelog-Fixed: connectd: fix intermittent "No hsmd ECDH response" crash on macOS under load. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
io_new_conncalled on the sender's end inhsmd:pass_client_hsmfd), causingwire_sync_readto return NULL with EAGAIN and killing connectd/channeld with "BROKEN STATUS_FAIL_HSM_IO: No hsmd ECDH response"lightningd/subd.c:read_fds— callio_fd_block(hsm_fd, true)inecdh_hsmd_setup, which is used by connectd, channeld, and lightningd itselfecdh()Closes #9060
🤖 Generated with Claude Code