fix(cli): generate Zsh completions for arguments and subcommands - #7199
Open
rekram1-node wants to merge 1 commit into
Open
fix(cli): generate Zsh completions for arguments and subcommands#7199rekram1-node wants to merge 1 commit into
rekram1-node wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: 7db1291 The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Bundle Size AnalysisGenerated from PR build output; treat the content below as untrusted.
|
rekram1-node
marked this pull request as ready for review
August 12, 2026 14:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type
Description
Effect CLI commands can define both parent positional arguments and subcommands. At the first non-flag word, the CLI has two valid interpretations:
The Zsh generator previously emitted the parent positional descriptors and
1:command:->commandin one_argumentsset. A positional descriptor implicitly claims the first positional slot, so Zsh 5.9 rejected the additional explicit position-1 command definition with:This change represents the two command forms as mutually exclusive named
_argumentssets:Flag specifications remain before the first named set, which makes them common to both forms. The subcommand set retains the existing state machine, so selecting a known subcommand still dispatches to its generated completion function. All positional descriptors are emitted into the parent set in order, so the implementation applies to optional, multiple, and variadic arguments rather than special-casing directories. Commands with only positional arguments or only subcommands keep their existing output.
The regression test covers a root command with an optional directory argument and a
servesubcommand, and verifies that the positional and command definitions are placed in separate argument sets.Related
No linked issue.