Border Texture - #722
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds country borders as a texture. This allows the ability to keep country contexts even when using displacement. It also maps the borders within the volumes or point clouds so you have continual reference through spacetime.
Also works with reprojections
Also works with irregular axis'
Known limitation
It doesn't work with reprojections from 0-360 degree data. I have added a warning to users of 0-360 degree data to expect strange behaviors with reprojection (The x-axis is also off)
I will open an issue. Not certain how to elegantly handle this scenario.
closes #336