Repository navigation
fix(vmm): write instance info atomically - #1553
Merged
Merged
Conversation
prepare_mr_config_v3() rewrites .instance_info on every launch with a truncating fs::write. A failed write or power loss leaves the file empty, losing instance_id_seed and with it the instance ID that keys the VM's persistent disk. Use safe_write, as the guest-reported instance info path already does. Signed-off-by: Kevin Wang <wy721@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
prepare_mr_config_v3()rewrites.instance_infoon every launch with a truncatingfs::write. A failed write (e.g. disk full) or power loss leaves the file empty, which dropsinstance_id_seed; the regenerated seed yields a different instance ID and the VM can no longer derive its existing disk key.Switch to
safe_write, which the guest-reportedinstance.infopath inapp.rsalready uses.