Repository navigation
feat(kms)!: turn off the public KMS key handover by default - #1552
Merged
kvinwang merged 1 commit intoNov 10, 2026
Merged
Conversation
Root-key handover now lives on the admin listener, so the public KMS.GetKmsKey entry is only needed while a 0.5.x KMS, or an onboarding request without source_token, still onboards from the cluster. Default core.onboard.public_key_handover to false in kms.toml and in the serde default, and make the refusal name the option to enable. The onboarding test runbooks onboard without a source token, so they now set the option on the source KMS explicitly. Signed-off-by: Kevin Wang <wy721@qq.com>
kvinwang
added a commit
that referenced
this pull request
Nov 10, 2026
#1552 turns core.onboard.public_key_handover off by default. The suite onboards without source_token, onboards 0.5.x destinations, and calls the public KMS.GetKmsKey directly, so every generated KMS config now enables it explicitly. Old KMS versions ignore the unknown key. tc-kms-onboard-005 drops the key instead of writing `false`, so its admin-listener step also covers the new default. Signed-off-by: Kevin Wang <wy721@qq.com>
kvinwang
added a commit
that referenced
this pull request
Nov 11, 2026
#1552 turns core.onboard.public_key_handover off by default. The suite onboards without source_token, onboards 0.5.x destinations, and calls the public KMS.GetKmsKey directly, so every generated KMS config now enables it explicitly. Old KMS versions ignore the unknown key. tc-kms-onboard-005 drops the key instead of writing `false`, so its admin-listener step also covers the new default. Signed-off-by: Kevin Wang <wy721@qq.com>
kvinwang
added a commit
that referenced
this pull request
Nov 11, 2026
Signed-off-by: Kevin Wang <wy721@qq.com>
This was referenced Nov 11, 2026
kvinwang
added a commit
that referenced
this pull request
Nov 11, 2026
#1552 turns core.onboard.public_key_handover off by default. The suite onboards without source_token, onboards 0.5.x destinations, and calls the public KMS.GetKmsKey directly, so every generated KMS config now enables it explicitly. Old KMS versions ignore the unknown key. tc-kms-onboard-005 drops the key instead of writing `false`, so its admin-listener step also covers the new default. Signed-off-by: Kevin Wang <wy721@qq.com>
kvinwang
added a commit
that referenced
this pull request
Nov 11, 2026
Signed-off-by: Kevin Wang <wy721@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the #1533 review (Blocking #3):
core.onboard.public_key_handovernow defaults tofalse, soKMS.GetKmsKeyis no longer served on the public port.kms.tomland the serde default are bothfalse. Every bundled config (dstack-appcompose files,dstack-cli-core,tools/dev-stack.sh) omits the key and inherits the default.source_token, or to enable the option. The onboard page explains this next to the token field.