Repository navigation
fix(auth-eth): report the current root epoch in wrong-kind rejections - #1538
Merged
Merged
Conversation
_checkAuthorization returned on a wrong-kind operation before filling in the current root epoch and chain hash, so the rejection reported (0, 0x0). The KMS then failed with "Root epoch not registered" instead of the rejection reason. Fill both in first, as the KMS README states and as auth-simple, auth-mock and dstack-auth already do. Found by a Halmos symbolic test. Signed-off-by: Kevin Wang <wy721@qq.com>
kvinwang
force-pushed
the
fix/auth-rejection-root-epoch
branch
from
November 9, 2026 06:12
2a93793 to
bace10c
Compare
kvinwang
changed the base branch from
feat/kms-epochs-three-commits
to
feat/kms-epochs-combined
November 9, 2026 06:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #1533.
_checkAuthorizationreturned on a wrong-kind operation before filling in the current root epoch and chain hash, soauthorizeKms/authorizeAppreported(0, 0x0). The KMS then failed with "Root epoch not registered" instead of the rejection reason. This fills both in first, as the KMS README states and as auth-simple, auth-mock and dstack-auth already do. Authorization decisions are unchanged.Found by the Halmos symbolic tests in #1537.
Validation: Linux 6.8.0-1028-intel x86_64, Forge 1.8.4, solc 0.8.24,
forge test --offline --ffi: 87 passed. The extendedtest_CheckAuthorization_RejectionIncludesActivatedEpochfails without the fix (0 != 1).