Repository navigation
refactor(dstack-volume): read the veritysetup root hash through one grammar - #1372
Merged
Merged
Conversation
kvinwang
force-pushed
the
refactor/verity-root-hash-grammar
branch
from
September 24, 2026 08:42
3ff42c3 to
acdec54
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
veritysetuproot-hash parsing existed twice:volume.rs(builder,veritysetup format) anddstack-volume(guest,veritysetup status), with different rules. The builder's version returnedSome("")for a bareRoot hash:line.This moves one
dstack_volume::parse_verity_root_hashinto the lib, used by both. It accepts both spellings and requires a non-empty hex value.Verification:
cargo test -p dstack-volume, clippy and fmt clean.