Repository navigation
fix(mountinfo): decode a trailing escape and \134 last - #1371
Merged
Merged
Conversation
kvinwang
force-pushed
the
fix/mountinfo-single-pass-decode
branch
from
September 24, 2026 08:42
7fa5ce3 to
9472722
Compare
`dstack-volume`'s decoder skipped an escape in the last four bytes, so a mount point ending in a space was never matched. The simulator's decoder replaced `\134` first, so a path containing a literal `\040` was decoded twice.
kvinwang
changed the title
kvinwang
force-pushed
the
fix/mountinfo-single-pass-decode
branch
from
September 24, 2026 09:11
9472722 to
f553893
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small decoding bugs in the mountinfo readers:
dstack-volume: the bounds check (index + 3 < len) skipped an escape in the last four bytes, so a mount point ending in\040was never decoded.tee-simulator:\134was replaced first, so a literal\040in a path (emitted by the kernel as\134040) was decoded twice.Verification