feat(installer): harden Dokploy provisioning - #173
Open
alti3 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the current minimal bootstrap installer with a production-hardened, automation-friendly installer while preserving explicit version pinning and a single-file Bash implementation.
This implements the operational recommendations from the installer review: observable failures, persistent logs, deeper preflight validation, safe existing-state handling, idempotent resources, verified downloads/images, structured upgrades, narrowly scoped rollback, post-install health validation, sanitized diagnostics, check mode, and dedicated CI coverage.
Installer changes
Safety and observability
set -Eeuo pipefail), a safeIFS, andumask 0770600logs under/var/log/dokployfor mutating runsDEBUG=1while disabling tracing around secret generation and creationPreflight and platform validation
amd64/arm64Docker and artifact integrity
latestto an immutable GitHub release tag and fails closed when resolution is ambiguousinstall.sh.sha256for the inspect-before-run installation flowExisting state, idempotency, upgrades, and recovery
auto,install,upgrade,repair,abort, andcheckactionsdatabase-safe; it never automatically restores a database dumpPorts, proxies, configuration, and health
ADVERTISE_ADDR,ENDPOINT_MODE, and positionalupdatecompatibility while documenting the new namesDocumentation and website changes
chmod 777, and declared success without health validationCI and tests
Adds a dedicated installer workflow with:
amd64, andarm64platform-contract checksLocal validation
Passed:
bash -n apps/website/public/install.shsha256sum --check apps/website/public/install.sh.sha256shellcheck --severity=style apps/website/public/install.sh tests/installer/install.batsshfmt -d -i 0 -ci apps/website/public/install.sh tests/installer/install.batsDOKPLOY_INSTALL_ACTION=checkexecution: correctly rejected the local WSL/Docker Desktop host and created no log or installation directoryExisting repository-wide checks remain blocked by baseline issues unrelated to this branch:
pnpm biome cireports existing formatting/lint failures, website typecheck reports existing application/motion typing failures, and the docs build later fails while prerendering/docs/api/reference-settingsbecause/settings.cleanRedisis missing from the current OpenAPI schema.Compatibility notes
shis unsupportedDOKPLOY_VERSION