fix: support macOS installation and add swarm init guidance - #140
fix: support macOS installation and add swarm init guidance#140cheonkyu wants to merge 2 commits into
Conversation
|
|
||
| # check if is running inside a container | ||
| if [ -f /.dockerenv ]; then | ||
| echo "This script must be run on Linux" >&2 |
There was a problem hiding this comment.
error message says "must be run on Linux" but script now supports macOS - update message to say "cannot be run inside a container" or similar
Additional Comments (1)
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time! |
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
|
+1 for this! The use case I have in mind: I've got a fairly low resource droplet that's well sized for my deployed services, but Dokploy requires a decent bit of memory overhead (1-2g) to be run alongside it. Running dokploy as a low-availability service locally feels like a pattern that could actually work pretty well, and this would unblock it for Mac folks. |
Description:
This PR introduces support for macOS (Docker Desktop) to the installation script. Currently, the script is restricted to Linux, but many developers use macOS for testing and local development.
Key Improvements:
Related Issue: dokploy/dokploy#2409
Greptile Summary
This PR adds macOS support to the Dokploy installation script by introducing OS detection, replacing Linux-specific commands with portable alternatives, and adding helpful guidance for Docker Swarm initialization issues.
Key changes:
IS_MACdetection to identify macOS environmentssscommand with portablecheck_port()helper that useslsofon macOSIssues found:
osascriptcommand for getting the private IP uses invalid AppleScript syntax and will always fail, falling back to127.0.0.1Confidence Score: 3/5
127.0.0.1on macOS instead of detecting the actual private IP, which defeats part of the purpose of the PR. The other issues are minor (misleading error messages, unnecessary root check).get_private_ip()function at line 193 requires immediate attention to fix the broken osascript commandLast reviewed commit: d98717a
(2/5) Greptile learns from your feedback when you react with thumbs up/down!