Skip to content

Add object and args unwrapping function - #47

Open
JosephAcernese wants to merge 1 commit into
mainfrom
bugfix/unwrap-job-args
Open

Add object and args unwrapping function#47
JosephAcernese wants to merge 1 commit into
mainfrom
bugfix/unwrap-job-args

Conversation

@JosephAcernese

Copy link
Copy Markdown
Contributor

This MR adds a class_manager method to unwrap proxy objects.

This partially resolves issue 46, but will likely need to be implemented in other parts of the API

@wiwichips

Copy link
Copy Markdown
Collaborator

Note to other reviewers; key change is here:

- self.js_ref.exec(*args)
+ self.js_ref.exec(*dry.class_manager.unwrap_args(args))

Because we had the special "_exec" method, it didn't go through the typical unwrap code it like it should have.


Sidenote: CI integration tests for job deployal from bifrost2 would be extremely valuable to make sure changes like this don't cause any surprises


Looks good to me

@wiwichips
wiwichips requested review from Severn-J-Lortie, Xmader and YarnSaw and removed request for Severn-J-Lortie July 29, 2026 20:59
@YarnSaw

YarnSaw commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Sidenote: CI integration tests for job deployal from bifrost2 would be extremely valuable to make sure changes like this don't cause any surprises

yeah, those would be great. Unfortunately the two options are to use localexec (which only works in node so.... can't use this one) or to have a keystore with DCCs in it that the CI pipeline can access. Unfortunately I've never used github CI before, so don't know how to create secure pipelines where people can't exfiltrate secrets. Probably not too hard, but a matter of dedicating the time to read up on how.

@YarnSaw

YarnSaw commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

LGTM. Not sure who the official release manager is for bifrost nowadays, is it me, @Xmader or @JosephAcernese?

@JosephAcernese

JosephAcernese commented Jul 31, 2026

Copy link
Copy Markdown
Contributor Author

I researched it a while ago. iirc to run a pipeline with secrets you can add secrets to the repository and use them in the pipeline. The only caveat is that you need to make it so pipelines can only be run by contributors, so people can't create & run pipelines which extract the secrets

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

All manually wrapped dcp-client functions need to unwrap Bifrost2 objects

3 participants