Skip to content

Fix update banner display issue for successful updates#4831

Merged
Gabriel Dufresne (GabrielDuf) merged 1 commit into
mainfrom
update-banner
May 27, 2026
Merged

Fix update banner display issue for successful updates#4831
Gabriel Dufresne (GabrielDuf) merged 1 commit into
mainfrom
update-banner

Conversation

@GabrielDuf
Copy link
Copy Markdown
Contributor

This pull request improves the reliability and correctness of the update logging and orphaned update detection logic in both UniGetUI and UniGetUI.Avalonia. The changes ensure that update log files are written atomically to prevent corruption, enhance version comparison logic to handle version strings with trailing zeros, and improve the clarity of log messages during orphaned update detection.

Version comparison improvements:

  • Introduced a new VersionsMatch method in both codebases to normalize version strings (e.g., treating "2026.1.11" and "2026.1.11.0" as equal), improving the accuracy of update attempt status checks.

Orphaned update attempt detection and logging:

  • Updated the orphaned update detection logic to:
    • Properly handle cases where no target version is recorded, skipping unnecessary warnings.
    • Use the new VersionsMatch method for more robust version equality checks. [
    • Improve warning and info log messages for better clarity and context.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants