test(public): add regression coverage for public route registration#352
Open
Ridanshi wants to merge 1 commit into
Open
test(public): add regression coverage for public route registration#352Ridanshi wants to merge 1 commit into
Ridanshi wants to merge 1 commit into
Conversation
Contributor
Author
|
PR #352 addresses issue #309 by adding focused regression coverage for the affected public profile routes. The underlying nested Covered routes:
The new tests verify:
No API contract changes or unrelated refactors were introduced. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #309
Summary
Adds focused regression coverage for the public profile routes involved in #309 to ensure runtime Fastify route-registration failures do not reappear.
The underlying implementation in
apps/backend/src/routes/public.tsis already fixed on latest upstream/main, so this PR intentionally avoids modifying route logic and instead protects against future regressions through targeted test coverage.Covered routes:
/api/public/:username/api/public/:username/card/:cardId/api/public/:username/qrTests Added
Added focused regression tests verifying:
200 OK200 OKNotes
Verification