Skip to content

feat: add CI pipeline with lint, typecheck, test, and PR title enforc…#323

Merged
ShantKhatri merged 1 commit into
Dev-Card:mainfrom
Midoriya-w:feat/ci-pipeline-clean
Jun 1, 2026
Merged

feat: add CI pipeline with lint, typecheck, test, and PR title enforc…#323
ShantKhatri merged 1 commit into
Dev-Card:mainfrom
Midoriya-w:feat/ci-pipeline-clean

Conversation

@Midoriya-w
Copy link
Copy Markdown
Contributor

Closes #45

Changes:

  • Added .github/workflows/ci.yml runs on every PR and push to main
    • Node.js 18 & 20 matrix
    • pnpm workspace-aware: typecheck, lint, test across all packages
    • Uploads coverage artifacts per Node version
  • Added .github/workflows/pr-title.yml enforces Conventional Commits format

@Harxhit Harxhit added the gssoc:approved Required label for every approved PR. Gives the base +50 points and enables contribution tracking. label May 24, 2026
Copy link
Copy Markdown
Contributor

@ShantKhatri ShantKhatri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add working proof for these workflows? For this you can raise the same pr against main of your forked repo and then try to replicate these workflows.

@Midoriya-w
Copy link
Copy Markdown
Contributor Author

hey @ShantKhatri ,Added working proof for both workflows by testing them against the main branch of my forked repository.

The workflows are successfully triggering on PR creation:
• CI workflow triggered correctly
• PR Title Check triggered correctly
• Workflow jobs initialized successfully

Workflow runs:
https://github.com/Midoriya-w/DevCard/actions
https://github.com/Midoriya-w/DevCard/pulls

Also attaching screenshots/logs for verification.
Screenshot 2026-05-27 230123
Screenshot 2026-05-27 230200
Screenshot 2026-05-27 230242

@ShantKhatri
Copy link
Copy Markdown
Contributor

hey @ShantKhatri ,Added working proof for both workflows by testing them against the main branch of my forked repository.

The workflows are successfully triggering on PR creation:

• CI workflow triggered correctly

• PR Title Check triggered correctly

• Workflow jobs initialized successfully

Workflow runs:

https://github.com/Midoriya-w/DevCard/actions

https://github.com/Midoriya-w/DevCard/pulls

Also attaching screenshots/logs for verification.

Screenshot 2026-05-27 230123 Screenshot 2026-05-27 230200 Screenshot 2026-05-27 230242

Thanks! Allow me some time for this.

@ShantKhatri ShantKhatri merged commit c535f20 into Dev-Card:main Jun 1, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc:approved Required label for every approved PR. Gives the base +50 points and enables contribution tracking.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

infrastructure: set up CI pipeline with lint, typecheck, and full test suite

3 participants