chore: use new model runner syntax#517
Conversation
82c5d5a to
f43d2bf
Compare
f43d2bf to
b841033
Compare
|
Rebased this branch onto current main (3ea9bfc), but git fetch https://github.com/defangdevs/samples.git lio/new-model-runner
git push --force-with-lease origin FETCH_HEAD:refs/heads/lio/new-model-runnerConflict resolution: both Pre-existing issues in the remaining crewai diff (in the PR as originally authored — I didn't change content during the rebase):
|
The worker still depended on the removed chat/embedding provider services, and no service was attached to the new top-level models, so the CHAT_URL/CHAT_MODEL/EMBEDDING_URL/EMBEDDING_MODEL env vars read by app/core/ai_clients.py were never injected. Attach both models to the worker via endpoint_var/model_var (compose.local.yaml inherits this through extends), rename the chat model back to match the local file, and drop x-defang-llm to match the other samples on the new syntax. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Sw7j9FYnbChZJbYArxbhuo
|
Fixed the issues above in a follow-up commit on the parked branch (a0afb77c): the worker's stale Verified with Same command as before to update this PR (now brings both commits): git fetch https://github.com/defangdevs/samples.git lio/new-model-runner
git push --force-with-lease origin FETCH_HEAD:refs/heads/lio/new-model-runner |
b841033 to
a0afb77
Compare
Cf. https://docs.docker.com/ai/compose/models-and-compose/
Samples Checklist
✅ All good!