Fix judge findings on the landed family redesign - #33
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the five concrete findings from the family redesign judge round against the merged PR #31 tree. One commit per finding.
Mobile admin-keys table overflow (family-breaking)
templates/mailing/operator/admin_api_keys.html: the Keys table now uses the established mobile stacking pattern copied fromclient_detail.html—table-wrap stack-tablewrapper plusdata-labelon every cell, so rows render as labelled rows at phone width instead of a clipped grid.Revoke rendered as a second accent-filled primary (family-breaking, one-primary-per-view)
class="danger"— the outlined destructive control already defined instatic/mailing/css/app.css(.dangervocabulary) and used the same way inclient_detail.html.Keys table sat outside the standard list container (polish)
section panel+panel-headermuted band with a key count, copied from the campaigns/client list templates.Dashboard summary strip missing vertical hairline cell dividers (polish)
stats-grid/stat): each strip cell painted an opaque background, and because cells carrymargin-right/bottom: -1pxso wrapped rows stay divided, each next cell's background painted exactly 1px over the previous cell's border hairline. Verified in-browser: computedborder-right: 1px solidpresent, adjacent cell rects overlap by exactly 1px, no divider pixels rendered.static/mailing/css/app.css: strip cells (.stat,.meta-grid > *) stay transparent and the container paints the surface/page color, so the hairlines show through the intentional 1px overlap. Rendered color is unchanged; dividers now render on the home summary strip, the processing strip, and detail-page strips/meta grids.Raw internal "Django admin" link on the operator-facing page (polish)
Verification:
uv run pytest754 passed (unchanged baseline),uv run ruff check .clean, plus pixel-level captures of the fixed home strip (divider columns present) and the Revoke button (outlined, not accent-filled).Out of scope, untouched: icon geometry, content container width, account menu depth, mobile header action layout.