Skip to content

Expect propagation tags in the first span of each trace chunk - #7426

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 4 commits into
mainfrom
sarahchen6/expect-propagation-tags-on-first-span
Jul 31, 2026
Merged

Expect propagation tags in the first span of each trace chunk#7426
gh-worker-dd-mergequeue-cf854d[bot] merged 4 commits into
mainfrom
sarahchen6/expect-propagation-tags-on-first-span

Conversation

@sarahchen6

@sarahchen6 sarahchen6 commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Motivation

Ensure that propagation tags are passed correctly to the first span of each trace chunk, not including the root span. This is expected behavior as noted in [RFC] Supporting 128-Bit TraceIds - Integrations.

Changes

Add a parametric test asserting _dd.p.tid and _dd.p.dm appear in the Meta map of the first span in each partial-flush chunk.

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Anything but tests/ or manifests/ is modified ? I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added, removed or renamed?

@sarahchen6
sarahchen6 requested review from a team as code owners July 30, 2026 20:51
@sarahchen6
sarahchen6 requested review from Anilm3, jandro996, manuel-alvarez-alvarez and mtoffl01 and removed request for a team July 30, 2026 20:51
@sarahchen6
sarahchen6 marked this pull request as draft July 30, 2026 20:51
@github-actions

Copy link
Copy Markdown
Contributor

CODEOWNERS have been resolved as:

manifests/cpp.yml                                                       @DataDog/dd-trace-cpp
manifests/java.yml                                                      @DataDog/asm-java @DataDog/apm-java
manifests/ruby.yml                                                      @DataDog/ruby-guild @DataDog/asm-ruby
manifests/rust.yml                                                      @DataDog/apm-rust
tests/parametric/test_partial_flushing.py                               @DataDog/system-tests-core @DataDog/apm-sdk-capabilities
tests/test_the_test/scenarios.json                                      @DataDog/system-tests-core

@sarahchen6

Copy link
Copy Markdown
Contributor Author

Sorry for the pings - meant to mark as Draft first 😅

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 21b5421875

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread tests/parametric/test_partial_flushing.py
Comment thread tests/parametric/test_partial_flushing.py
@datadog-prod-us1-3

datadog-prod-us1-3 Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Tests

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: efaa70e | Docs | Datadog PR Page | Give us feedback!

@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit d56b98b into main Jul 31, 2026
432 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the sarahchen6/expect-propagation-tags-on-first-span branch July 31, 2026 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants