Expect propagation tags in the first span of each trace chunk - #7426
Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 4 commits intoJul 31, 2026
Merged
Conversation
sarahchen6
requested review from
Anilm3,
jandro996,
manuel-alvarez-alvarez and
mtoffl01
and removed request for
a team
July 30, 2026 20:51
sarahchen6
marked this pull request as draft
July 30, 2026 20:51
Contributor
|
|
Contributor
Author
|
Sorry for the pings - meant to mark as Draft first 😅 |
mtoffl01
approved these changes
Jul 30, 2026
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 21b5421875
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
nccatoni
approved these changes
Jul 31, 2026
Contributor
🎉 All green!🧪 All tests passed 🔗 Commit SHA: efaa70e | Docs | Datadog PR Page | Give us feedback! |
sarahchen6
marked this pull request as ready for review
July 31, 2026 15:31
gh-worker-dd-mergequeue-cf854d
Bot
deleted the
sarahchen6/expect-propagation-tags-on-first-span
branch
July 31, 2026 15:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Ensure that propagation tags are passed correctly to the first span of each trace chunk, not including the root span. This is expected behavior as noted in [RFC] Supporting 128-Bit TraceIds - Integrations.
Changes
Add a parametric test asserting
_dd.p.tidand_dd.p.dmappear in theMetamap of the first span in each partial-flush chunk.Workflow
🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
tests/ormanifests/is modified ? I have the approval from R&P teambuild-XXX-imagelabel is present