[DO NOT MERGE] Test fixture: editorial issues for dashboard review composer by buraizu · Pull Request #38672 · DataDog/documentation

buraizu · 2026-07-31T21:57:20Z

[DO NOT MERGE] Test fixture for docs on-call dashboard

This PR exists only to exercise the docs team dashboard's PR review composer. It intentionally introduces editorial issues into a single FAQ page. Do not merge it. Close it once dashboard testing is finished.

What's here

Five deliberate edits to content/en/metrics/faq/updating-to-distribution-metrics-faq.md, chosen to produce a specific mix of review findings:

Three that should produce inline comments with direct replacement suggestions:

Intro paragraph — utilize and in order to (word-list swaps).
Nested list item — easily and leverage. This one is indented two spaces on purpose, to verify suggestion blocks preserve leading indentation.
Manage Tags paragraph — first-person Our, allows you to, and a passive trailing clause.

Two that should produce general (review-body) comments:

A new ## Percentile Configuration Best Practices section — heading breaks the file's question pattern and uses title case instead of sentence case; body is passive throughout and restates content from an earlier section.
A bulleted list under the bulk-percentiles section — items are not parallel (imperative, declarative, and a bare noun phrase) with inconsistent capitalization and end punctuation.

No new technical claims are introduced; edits 4 and 5 restate behavior already documented on the page.

Ready for merge

Ready for merge

github-actions · 2026-07-31T22:03:30Z

Preview links (active after the `build_preview` check completes)

Modified Files

buraizu

New section restates existing content and breaks the page's heading pattern

Every other heading on this page is phrased as a question, matching the page's FAQ format; this new heading is a title-case noun phrase, breaking both the question pattern and the sentence-case rule for headings. Its content — that custom-metric counts for percentile-enabled distributions are counted like other metric types — already appears earlier on the page in the "How does this new pipeline for Distributions affect me?" section, and the body is written entirely in passive voice.

Suggested fix: Remove this section since it doesn't add new information beyond what's already stated earlier on the page. If it's kept, rephrase the heading as a question in sentence case and rewrite the body in active voice.

Bulk-configure bullet list is not parallel

The four list items mix grammatical forms (a declarative statement, an imperative instruction, another declarative statement, and a bare noun phrase), and are inconsistent in capitalization and end punctuation — only one item is capitalized and only one ends with a period.

Suggested fix: Confirm that your wildcard pattern matches only the intended metric names.

test

jhgilbert · 2026-08-06T14:36:02Z

[Automated message] This PR has merge conflicts created by the docs repo reorg project. Because this PR is marked as a work in progress, no attempt was made to auto-resolve the conflicts. When your PR is finished, you can queue your PR for an auto-fix by removing the WORK IN PROGRESS label and the astro-reorg-skip label. Your PR will be processed in the next batch of attempted auto-fixes.

This is an automated comment, but if you have a question, you can mention me in this PR (external contributors) or reach out in #docs-repo-reorg-support on Slack (internal contributors).

buraizu

PR description doesn't disclose full scope of diff

The description states the edits are confined to updating-to-distribution-metrics-faq.md, but the diff also modifies rollup-for-distributions-with-percentiles.md and replaces the manage-tags.png image, none of which are mentioned.

Suggested fix: Update the PR description to reflect the actual files changed, or confirm the additional changes are intentional.

test

buraizu

PR description doesn't disclose full scope of diff

The description states the edits are confined to updating-to-distribution-metrics-faq.md, but the diff also modifies rollup-for-distributions-with-percentiles.md and replaces the manage-tags.png image, none of which are mentioned.

Suggested fix: Update the PR description to reflect the actual files changed, or confirm the additional changes are intentional.

test4
test5

buraizu · 2026-08-07T19:13:00Z

+## Rollup Interval Best Practices
+
+It is recommended that a rollup interval be chosen based on the range being queried. As described above, the rollup `<aggregator>` parameter no longer affects distributions queried with percentiles, so only the `<time interval>` needs to be specified.


test1

Suggested fix: test2

buraizu · 2026-08-07T19:13:00Z


 ## Does this update to rollup change the values of my existing queries on distributions with percentiles? 
-No - your existing queries are unaffected. The `.rollup <aggregator>` parameter has been removed because it had no effect on query results but caused user confusion for how the resulting value was calculated. 
+No - your existing queries are unaffected. We removed the `.rollup <aggregator>` parameter in order to reduce confusion, since it had no effect on query results but caused user confusion for how the resulting value was calculated. 


"In order to" is wordier than "to," the sentence mentions confusion twice, and the switch to first-person "We removed" introduces a voice inconsistent with the rest of the page.

Suggested change

No - your existing queries are unaffected. We removed the `.rollup <aggregator>` parameter in order to reduce confusion, since it had no effect on query results but caused user confusion for how the resulting value was calculated.

test3

buraizu · 2026-08-07T19:13:00Z

+- wildcards match every metric name that fits the pattern
+- Review the estimated custom metric count before you save.
+- percentile aggregations count toward your custom metrics total
+- impact on existing tag configurations


The four list items mix grammatical forms (imperative, declarative, and a bare noun phrase) with inconsistent capitalization and end punctuation, making the list harder to scan.

Suggested fix: Wildcards match every metric name that fits the pattern.

buraizu · 2026-08-07T19:13:00Z


 ## What has been updated for distributions with percentiles?
-You no longer need to specify an additional time aggregator (as in `.rollup(avg)`) when you've already selected `p50`, `p75`, `p90`, `p95`, or `p99`. You only need to specify a rollup `<time interval>` which determines the interval of time your data is aggregated over. 
+You no longer need to utilize an additional time aggregator (as in `.rollup(avg)`) when you've already selected `p50`, `p75`, `p90`, `p95`, or `p99`. You only need to specify a rollup `<time interval>`, which easily determines the interval of time your data is aggregated over. 


"Utilize" should be "use." "Easily determines" is an odd modifier placement — it implies the interval itself does something "easily," rather than the parameter making configuration easy.

Suggested change

You no longer need to utilize an additional time aggregator (as in `.rollup(avg)`) when you've already selected `p50`, `p75`, `p90`, `p95`, or `p99`. You only need to specify a rollup `<time interval>`, which easily determines the interval of time your data is aggregated over.

You no longer need to use an additional time aggregator (as in `.rollup(avg)`) when you've already selected `p50`, `p75`, `p90`, `p95`, or `p99`. You only need to specify a rollup `<time interval>`, which determines the interval of time your data is aggregated over.

buraizu · 2026-08-07T19:13:00Z

 ## Why has my distribution metrics page been deprecated?

-Datadog has released a new pipeline for calculating globally accurate percentiles for your distribution metrics --- this unlocks more query functionality and an easier configuration workflow for distributions.
+Datadog has released a new pipeline that you can utilize in order to calculate globally accurate percentiles for your distribution metrics. This gives you more query functionality and an easier configuration workflow for distributions.


"Utilize" and "in order to" are both unnecessarily wordy substitutes for "use" and "to."

Suggested change

Datadog has released a new pipeline that you can utilize in order to calculate globally accurate percentiles for your distribution metrics. This gives you more query functionality and an easier configuration workflow for distributions.

Datadog has released a new pipeline that you can use to calculate globally accurate percentiles for your distribution metrics. This gives you more query functionality and an easier configuration workflow for distributions.

buraizu · 2026-08-07T19:13:00Z

  - Boolean filtered queries are now available with distribution metrics with percentiles, so that you can write queries like: `p99:request_latency_distribution{app:A OR app:B} by {app}`.
 - **Easier tag configuration and percentile aggregation workflows**:
-  - All tag configuration-percentile aggregations are managed in one centralized location on the [Metrics Summary][1] page.
+  - All tag configuration-percentile aggregations are managed in one centralized location on the [Metrics Summary][1] page, so you can easily leverage them across your organization.


"Leverage" is jargon for "use," and "easily" is an unnecessary filler adverb that doesn't add information.

Suggested change

- All tag configuration-percentile aggregations are managed in one centralized location on the [Metrics Summary][1] page, so you can easily leverage them across your organization.

- All tag configuration-percentile aggregations are managed in one centralized location on the [Metrics Summary][1] page, so you can use them across your organization.

buraizu · 2026-08-07T19:13:00Z

 {{< img src="metrics/faq/sketch-db-migration-faq/configure-tags.png" alt="Configure tags">}}

-Click the {{< ui >}}Manage Tags{{< /ui >}} button to configure which tags are queryable on a particular metric. You can preview the new number of indexed custom metrics from your tag configuration before saving it.
+Click the {{< ui >}}Manage Tags{{< /ui >}} button to configure which tags are queryable on a particular metric. Our UI allows you to preview the new number of indexed custom metrics from your tag configuration before it is saved by you.


"Our UI" uses first person where the rest of the page speaks directly to the reader about the product. "Before it is saved by you" is an awkward passive construction; the active form reads more naturally.

Suggested change

Click the {{< ui >}}Manage Tags{{< /ui >}} button to configure which tags are queryable on a particular metric. Our UI allows you to preview the new number of indexed custom metrics from your tag configuration before it is saved by you.

Click the {{< ui >}}Manage Tags{{< /ui >}} button to configure which tags are queryable on a particular metric. You can preview the new number of indexed custom metrics from your tag configuration before you save it.

buraizu · 2026-08-07T19:13:00Z

@@ -8,10 +8,10 @@ is_beta: false
 Time aggregation `(.rollup(<aggregator>, <time interval>)` and how it works with distributions with percentile aggregations has changed.

 ## Does this update to rollup change the values of my existing queries on distributions with percentiles? 


Suggested change

## Does this update to rollup change the values of my existing queries on distributions with percentiles?

test6

Add deliberate editorial issues for review composer testing

2f2830e

buraizu requested a review from a team as a code owner July 31, 2026 21:57

github-actions Bot added the FAQ Content impacting a FAQ label Jul 31, 2026

buraizu added Do Not Merge Just do not merge this PR :) WORK IN PROGRESS No review needed, it's a wip ;) labels Jul 31, 2026

buraizu self-assigned this Jul 31, 2026

buraizu commented Jul 31, 2026

View reviewed changes

buraizu commented Aug 1, 2026

View reviewed changes

Comment thread content/en/metrics/faq/updating-to-distribution-metrics-faq.md

buraizu added 2 commits July 31, 2026 17:40

Add second test file with editorial issues for dashboard testing

615df64

Swap manage-tags.png for the Datadog logo to test image rendering

25f69da

github-actions Bot added the Images Images are added/removed with this PR label Aug 1, 2026

jhgilbert added astro-reorg-skip Needs manual conflict resolution after replatforming reorg astro-reorg-processed Needs manual conflict resolution after replatforming reorg labels Aug 6, 2026

buraizu commented Aug 7, 2026

View reviewed changes

buraizu closed this Aug 7, 2026

buraizu deleted the bryce/oc-dashboard-test branch August 7, 2026 20:08

		## Rollup Interval Best Practices

		It is recommended that a rollup interval be chosen based on the range being queried. As described above, the rollup `<aggregator>` parameter no longer affects distributions queried with percentiles, so only the `<time interval>` needs to be specified.

	No - your existing queries are unaffected. We removed the `.rollup <aggregator>` parameter in order to reduce confusion, since it had no effect on query results but caused user confusion for how the resulting value was calculated.
	test3

	You no longer need to utilize an additional time aggregator (as in `.rollup(avg)`) when you've already selected `p50`, `p75`, `p90`, `p95`, or `p99`. You only need to specify a rollup `<time interval>`, which easily determines the interval of time your data is aggregated over.
	You no longer need to use an additional time aggregator (as in `.rollup(avg)`) when you've already selected `p50`, `p75`, `p90`, `p95`, or `p99`. You only need to specify a rollup `<time interval>`, which determines the interval of time your data is aggregated over.

	Datadog has released a new pipeline that you can utilize in order to calculate globally accurate percentiles for your distribution metrics. This gives you more query functionality and an easier configuration workflow for distributions.
	Datadog has released a new pipeline that you can use to calculate globally accurate percentiles for your distribution metrics. This gives you more query functionality and an easier configuration workflow for distributions.

	- All tag configuration-percentile aggregations are managed in one centralized location on the [Metrics Summary][1] page, so you can easily leverage them across your organization.
	- All tag configuration-percentile aggregations are managed in one centralized location on the [Metrics Summary][1] page, so you can use them across your organization.

	Click the {{< ui >}}Manage Tags{{< /ui >}} button to configure which tags are queryable on a particular metric. Our UI allows you to preview the new number of indexed custom metrics from your tag configuration before it is saved by you.
	Click the {{< ui >}}Manage Tags{{< /ui >}} button to configure which tags are queryable on a particular metric. You can preview the new number of indexed custom metrics from your tag configuration before you save it.

		@@ -8,10 +8,10 @@ is_beta: false
		Time aggregation `(.rollup(<aggregator>, <time interval>)` and how it works with distributions with percentile aggregations has changed.

		## Does this update to rollup change the values of my existing queries on distributions with percentiles?

	## Does this update to rollup change the values of my existing queries on distributions with percentiles?
	test6

Uh oh!

Conversation

buraizu commented Jul 31, 2026

[DO NOT MERGE] Test fixture for docs on-call dashboard

What's here

Ready for merge

Uh oh!

github-actions Bot commented Jul 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Preview links (active after the build_preview check completes)

Modified Files

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

buraizu left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jhgilbert commented Aug 6, 2026

Uh oh!

buraizu left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

buraizu left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-actions Bot commented Jul 31, 2026 •

edited

Loading

Preview links (active after the `build_preview` check completes)