When developing in dunetrigger, we ran into an annoying segfault that was due to not properly including the abstract factory in a larsoft algorithm.
The solution was just add back to the CMakeLists what was missing (git was a bit naughty).
The problem was that due to missing initialization, the map had invalid pointers. Is it worth considering adding some valid pointer check here?
|
creation_map& makers = get_makers(); |
I know it's a very special case that probably does not matter for online, but Wes said he could not hurt to do it. Feel free to discard the issue if you think there's no need.
When developing in dunetrigger, we ran into an annoying segfault that was due to not properly including the abstract factory in a larsoft algorithm.
The solution was just add back to the CMakeLists what was missing (git was a bit naughty).
The problem was that due to missing initialization, the map had invalid pointers. Is it worth considering adding some valid pointer check here?
triggeralgs/include/triggeralgs/AbstractFactory.hxx
Line 27 in ffa3de1
I know it's a very special case that probably does not matter for online, but Wes said he could not hurt to do it. Feel free to discard the issue if you think there's no need.