srv6: resolve nexthop groups in sr6_output - #665
Conversation
When FRR wraps every nexthop in a group, fib6_lookup returns a group nexthop instead of the underlying L3 nexthop. In sr6_output, the secondary FIB lookup for the SID prefix is followed by a call to sr_tunsrc_get which reads nh->iface_id directly. Group nexthops have iface_id set to GR_IFACE_ID_UNDEF, causing sr_tunsrc_get to fail and dropping the packet at sr6_source_no_route. Resolve the group to its member nexthop right after the fib6_lookup so that subsequent field accesses see the actual L3 nexthop. Signed-off-by: Robin Jarry <rjarry@redhat.com>
|
Warning Review limit reached
Next review available in: 59 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Same issue may happen in many places. I'll close this and rework it to include the nexthop group resolution inline with fib{4,6}_lookup. |
When FRR wraps every nexthop in a group, fib6_lookup returns a group nexthop instead of the underlying L3 nexthop. In sr6_output, the secondary FIB lookup for the SID prefix is followed by a call to sr_tunsrc_get which reads nh->iface_id directly. Group nexthops have iface_id set to GR_IFACE_ID_UNDEF, causing sr_tunsrc_get to fail and dropping the packet at sr6_source_no_route.
Resolve the group to its member nexthop right after the fib6_lookup so that subsequent field accesses see the actual L3 nexthop.