Skip to content

srv6: resolve nexthop groups in sr6_output - #665

Closed
rjarry wants to merge 1 commit into
DPDK:mainfrom
rjarry:srv6-nhg
Closed

srv6: resolve nexthop groups in sr6_output#665
rjarry wants to merge 1 commit into
DPDK:mainfrom
rjarry:srv6-nhg

Conversation

@rjarry

@rjarry rjarry commented Jul 24, 2026

Copy link
Copy Markdown
Collaborator

When FRR wraps every nexthop in a group, fib6_lookup returns a group nexthop instead of the underlying L3 nexthop. In sr6_output, the secondary FIB lookup for the SID prefix is followed by a call to sr_tunsrc_get which reads nh->iface_id directly. Group nexthops have iface_id set to GR_IFACE_ID_UNDEF, causing sr_tunsrc_get to fail and dropping the packet at sr6_source_no_route.

Resolve the group to its member nexthop right after the fib6_lookup so that subsequent field accesses see the actual L3 nexthop.

When FRR wraps every nexthop in a group, fib6_lookup returns a group
nexthop instead of the underlying L3 nexthop. In sr6_output, the
secondary FIB lookup for the SID prefix is followed by a call to
sr_tunsrc_get which reads nh->iface_id directly. Group nexthops have
iface_id set to GR_IFACE_ID_UNDEF, causing sr_tunsrc_get to fail and
dropping the packet at sr6_source_no_route.

Resolve the group to its member nexthop right after the fib6_lookup so
that subsequent field accesses see the actual L3 nexthop.

Signed-off-by: Robin Jarry <rjarry@redhat.com>
@coderabbitai

coderabbitai Bot commented Jul 24, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@rjarry, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 59 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 0fdbc1c7-f792-4333-9e40-8db56368971b

📥 Commits

Reviewing files that changed from the base of the PR and between f28ef49 and 9b0f12c.

📒 Files selected for processing (1)
  • modules/srv6/datapath/srv6_output.c

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@rjarry
rjarry requested a review from maxime-leroy July 27, 2026 11:44
@rjarry

rjarry commented Jul 27, 2026

Copy link
Copy Markdown
Collaborator Author

Same issue may happen in many places. I'll close this and rework it to include the nexthop group resolution inline with fib{4,6}_lookup.

@rjarry rjarry closed this Jul 27, 2026
@rjarry
rjarry deleted the srv6-nhg branch July 27, 2026 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant