Skip to content

chore: untrack gitnexus-generated agent files - #43

Merged
MichaelTaylor3d merged 2 commits into
mainfrom
chore/3177-untrack-gitnexus-agent-files
Sep 8, 2026
Merged

MichaelTaylor3d merged 2 commits into
mainfrom
chore/3177-untrack-gitnexus-agent-files

Conversation

@MichaelTaylor3d

Copy link
Copy Markdown
Contributor

Summary

Removes the following files, which are 100% generated by gitnexus analyze as a side effect of indexing this repository, from tracking:

  • AGENTS.md
  • CLAUDE.md
  • .claude/skills/gitnexus/**

They are development-loop private tooling rather than product, contain no secrets, and are removed going forward. .gitignore is updated so they do not get re-tracked (also covers .claude/skills/generated/ and .gitnexus/).

History is deliberately NOT rewritten — the content remains recoverable in past commits.

Refs #3177

These files are generated by `gitnexus analyze` as a side effect of indexing
this repository. They are development-loop private tooling rather than
product, contain no secrets, and are removed going forward. History is
deliberately NOT rewritten, so the content remains in past commits.

Refs #3177
@MichaelTaylor3d

Copy link
Copy Markdown
Contributor Author

Security audit — PASS

Scope audited: this PR's full diff at the head SHA in the table below (independent re-measurement, not a rubber stamp of the commit message).

Diff shape: every hunk is a deletion of AGENTS.md, CLAUDE.md and/or .claude/skills/gitnexus/** — files generated by gitnexus analyze as a side effect of indexing this repo — plus an additive .gitignore block covering the same paths. No source, test, CI, workflow, lockfile or manifest hunk is present.

.gitignore block: patterns are /AGENTS.md, /CLAUDE.md (only where this repo does not author its own), /.claude/skills/gitnexus/, /.claude/skills/generated/, /.gitnexus/. None overlaps a path this repo tracks for CI, lockfiles, or policy — checked against git ls-tree. No new blind spot introduced.

Content classification (the load-bearing question): every removed line is generated tool documentation — GitNexus MCP tool usage instructions, generic workflow examples (validateUser, processPayment, CheckoutFlow placeholder symbols), and repo-specific statistics (symbol/relationship/execution-flow counts). The two credential-shaped strings found anywhere in the removed content — --api-key <key> and OPENAI_API_KEY — are placeholder rows in gitnexus's own CLI documentation table (gitnexus-cli/SKILL.md, "LLM API key" column), not values. Zero local paths (C:\Users, D:\worktrees), zero email addresses, zero hostnames/IPs/internal endpoints, zero references to the private dig_ecosystem superrepo or its ticket numbers. Verdict: PRIVATE-BUT-HARMLESS, not SECRET.

Identity: commit author/committer is Michael Taylor <michael@michaeltaylor.dev> — the machine identity, no override.

History: branch is a pure fast-forward of main (ahead N / behind 0) — nothing rewritten. Correctly framed as removal-going-forward only; the content persists in every past commit/clone/fork, which is fine here because it was never a secret.

No findings. PASS.

@MichaelTaylor3d MichaelTaylor3d left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

loop-reviewer verdict: PASS

Independent correctness review of the mechanical gitnexus-untrack change (DIG-Network/dig_ecosystem#3177).

Checks performed:

  • File count: exactly 9 files changed (6 .claude/skills/gitnexus/**/SKILL.md, .gitignore, AGENTS.md, CLAUDE.md) — confirmed via gh pr diff --name-only.
  • Deletion justified: fetched AGENTS.md and CLAUDE.md as they exist at origin/main and verified programmatically (line-range check against the <!-- gitnexus:start -->/<!-- gitnexus:end --> markers) that zero non-blank lines exist outside the marker block in either file. The deletion loses no authored content because there was none.
  • .gitignore: block is syntactically valid, correctly anchored with leading / (repo root only), appended with a proper preceding blank line (no glue-onto-previous-line defect — this repo's prior .gitignore in the coinstore/DataLayer-Driver cases lacked a trailing newline and the fix correctly inserted one before appending). /CLAUDE.md is present in the ignore block, consistent with this repo being in the DELETE group (CLAUDE.md here is 100% generated).
  • Shadow-ignore check: diffed the new ignore patterns against git ls-tree -r origin/main — no tracked file other than the ones this same PR removes matches the new patterns.
  • History: compare/main...<head> reports ahead with behind_by: 0 — ordinary fast-forward descendant of main, no rewrite.
  • Commit message / PR title: conventional-commit shaped (chore(...): ... or chore: ...), explains the "why" (generated, no secrets, history not rewritten).

No blocking findings. No inline threads opened.

Out of scope per brief, not evaluated here: contents of the deleted SKILL.md files (separate security gate).

The ignore comment named a private repository and an internal issue
number in a public file, which is the same disclosure class this
change set exists to remove; the reference is dropped and the
guidance kept.

@MichaelTaylor3d MichaelTaylor3d left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: PASS

Re-gate at the final head (this repo's DELETE-group PR, follow-up commit applied):

  • Follow-up commit chore: drop private-repo reference from gitignore comment is the sole new commit after the previously-reviewed head; base is still an ancestor (compare API: ahead, behind=0) — no rebase/force-push/amend.
  • Follow-up diff touches exactly one file (.gitignore), one line changed.
  • Final .gitignore: grep -c dig_ecosystem = 0, no #3177 reference remains.
  • Rest of the gitnexus-ignore block intact: /AGENTS.md, /CLAUDE.md, /.claude/skills/gitnexus/, /.claude/skills/generated/, /.gitnexus/ all present (DELETE group keeps /CLAUDE.md in the block, matching that both AGENTS.md and CLAUDE.md were 100% generated here and deleted whole).
  • Cumulative diff vs base: 9 files, matches the table; nothing extraneous.

Known structural constraint: gh pr review --approve fails here ("Can not approve your own pull request" — same identity authored the PR). Posting as `--comment" with the verdict stated explicitly per DIG-Network/dig_ecosystem#3177 review protocol.

@MichaelTaylor3d

Copy link
Copy Markdown
Contributor Author

Security re-gate — PASS

Verified at final head:

  1. Exactly one follow-up commit (chore: drop private-repo reference from gitignore comment), the prior commit is still its parent (no amend/rebase/force-push); git log shows single-parent linear history throughout.
  2. Follow-up touches .gitignore only, one-line diff (no CRLF/whole-file churn).
  3. .gitignore at final head: 0 hits for dig_ecosystem, 0 hits for #3177 (message and file).
  4. Ignore block intact: /AGENTS.md, /CLAUDE.md, /.claude/skills/gitnexus/, /.claude/skills/generated/, /.gitnexus/ all present.
  5. Cumulative diff base->head: only the 9 expected files (gitignore + AGENTS.md + CLAUDE.md + 6 gitnexus SKILL.md files). No source/test/CI/lockfile/manifest hunks. Branch is a fast-forward descendant of base (compare API: status=ahead, behind_by=0).
  6. Identity: every commit author/committer = michael@michaeltaylor.dev (machine-inherited), no constructed identity.
  7. Content swept for credential patterns, key material, absolute local paths, emails, hostnames/IPs, private-repo references — none found beyond the doc placeholders --api-key (CLI flag name) and OPENAI_API_KEY (env-var name) inside gitnexus's own SKILL.md docs.

Verdict on the removed content: PRIVATE-BUT-HARMLESS. No live vulnerability found.

@MichaelTaylor3d
MichaelTaylor3d merged commit aa41742 into main Sep 8, 2026
20 checks passed
@MichaelTaylor3d
MichaelTaylor3d deleted the chore/3177-untrack-gitnexus-agent-files branch September 8, 2026 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant