Repository navigation
Backport MCP for Unity v10.3.0 to Unity 2020.3 LTS - #1497
Closed
akhilkalyani wants to merge 2 commits into
Closed
akhilkalyani wants to merge 2 commits into
akhilkalyani wants to merge 2 commits into
Conversation
Port the Unity package (MCPForUnity) so it compiles and runs on Unity 2020.3 (C# 8, .NET 4.x profile). The Python server is unchanged (mcpforunityserver==10.3.0). - Rewrite C# 9 syntax to C# 8: target-typed new(), `is not` patterns, or/and patterns, target-typed conditionals, ranges. - Replace .NET Standard 2.1 APIs missing from 2020.3 with Editor/Compat/NetCompat.cs (string overloads, Math.Clamp, Path.GetRelativePath, ProcessStartInfo.ArgumentList, PBKDF2-SHA256). - Guard Unity 2021+ editor APIs behind UNITY_2021_2/2021_3_OR_NEWER with 2020.3 fallbacks; add stand-ins for DropdownField, NamedBuildTarget, StandaloneBuildSubtarget and PackageInfo.GetAllRegisteredPackages. - Runtime UI Toolkit actions of manage_ui return a clear error on 2020.3. - Drop the com.unity.nuget.newtonsoft-json dependency (conflicts with jillejr Newtonsoft packages), reference the TestRunner assemblies explicitly, and disable upstream update prompts. - Add UNITY-2020.3.md and tools/unity-2020.3-backport (compile check, C# 9->8 rewriter, tarball packer). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
Unity 2020.3 does not reliably call CreateGUI again for an EditorWindow restored after a domain reload, so an already-open MCP window (or one whose first CreateGUI failed) stayed blank and the menu only re-focused it. - MCP window: build the UI from OnEnable (delayCall), OnFocus and ShowWindow when it is missing, and replace a leftover window whose UI was never built with a fresh one. - Setup and EditorPrefs windows: rebuild from OnEnable when empty. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port the Unity package (MCPForUnity) so it compiles and runs on Unity 2020.3 (C# 8, .NET 4.x profile). The Python server is unchanged (mcpforunityserver==10.3.0).
is notpatterns, or/and patterns, target-typed conditionals, ranges.Description
Type of Change
Changes Made
Compatibility / Package Source
#beta,#main, tag, branch, orfile:):Packages/packages-lock.json(if using a Git package URL):Testing/Screenshots/Recordings
cd Server && uv run pytest tests/ -v)Documentation Updates
tools/UPDATE_DOCS_PROMPT.md(recommended)Related Issues
Additional Notes