Skip to content

ci: move workflows from Node.js 20 to Node.js 24 - #1488

Open
saalvarem wants to merge 1 commit into
CoplayDev:betafrom
saalvarem:ci/node-24
Open

saalvarem wants to merge 1 commit into
CoplayDev:betafrom
saalvarem:ci/node-24

Conversation

@saalvarem

@saalvarem saalvarem commented Oct 22, 2026 •

Copy link
Copy Markdown

Description

Moves the three workflows that set up Node.js (docs-deploy, release, stats) from Node.js 20 to Node.js 24.

Why: Node.js 20 reached end-of-life on 2026-04-30 and no longer receives security fixes. The October 21, 2026 Node.js security release fixed 10 vulnerabilities, including a high-severity RCE in the Brotli decoder (CVE-2026-111497), but only for 22.x, 24.x, and 26.x. With node-version: 20, these jobs stay on an unpatched runtime. Node.js 24 is the current LTS line.

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Refactoring (no functional changes)
  • Test update

Changes Made

  • .github/workflows/docs-deploy.yml: node-version: 20 → 24
  • .github/workflows/release.yml: node-version: "20" → "24"
  • .github/workflows/stats.yml: node-version: 20 → 24

website/package.json already declares "node": ">=20.9.0", so no other changes are needed.

Compatibility / Package Source

  • Unity version(s) tested: N/A (CI-only change)
  • Package source used: N/A
  • Resolved commit hash: N/A

Testing/Screenshots/Recordings

  • Python tests (cd Server && uv run pytest tests/ -v)
  • Unity EditMode tests
  • Unity PlayMode tests
  • Package import/compile check
  • Not applicable (explain why in Additional Notes)

Documentation Updates

  • I have added/removed/modified tools or resources
  • If yes, I have updated all documentation files using:
    • The LLM prompt at tools/UPDATE_DOCS_PROMPT.md (recommended)
    • Manual review of the generated changes

Related Issues

None.

Additional Notes

This only changes the Node.js version used by CI, so it doesn't touch the Unity package or the Python server. Checked locally on Node.js v24.22.1:

  • website: npm ci && npm run build succeeds (the same steps docs-deploy runs).
  • node website/scripts/fetch-stats.mjs runs without errors (the stats job).
  • python3 tools/generate_mcpb.py builds the .mcpb bundle through npx @anthropic-ai/mcpb pack (the Node step in the release job).

The docs-deploy run on this PR also builds the site on Node.js 24.

Summary by CodeRabbit

  • Chores
    • Updated the Node.js version used for documentation builds, release bundle generation, and statistics processing from version 20 to version 24.
    • These changes affect automated project processes; no user-facing features or application behavior were changed.

Node.js 20 reached end-of-life in April 2026 and no longer receives
security fixes, including the October 2026 security release
(CVE-2026-111497 and others). Node.js 24 is the current LTS line.
@coderabbitai

coderabbitai Bot commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 73500633-5319-491d-b02d-298d0863d0af
📥 Commits

Reviewing files that changed from the base of the PR and between ed4e205 and 103b0a5.

📒 Files selected for processing: 3
  • .github/workflows/docs-deploy.yml
  • .github/workflows/release.yml
  • .github/workflows/stats.yml

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

📝 Walkthrough

Three GitHub Actions workflows now configure Node.js 24 instead of Node.js 20: the documentation build, MCPB publishing, and stats workflows.

Changes: Workflow Node.js runtime updates

Layer / File(s) Summary
Update workflow runtimes
.github/workflows/docs-deploy.yml, .github/workflows/release.yml, .github/workflows/stats.yml
Each workflow now configures Node.js 24 instead of Node.js 20.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Suggested reviewers: scriptwonder, bryankthompson

Merge Risk: ⚪ Minimal · up to 103b0

No actionable merge-blocking risk was found in the workflow runtime updates.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title clearly and concisely describes the main change: updating the CI workflows from Node.js 20 to Node.js 24.
Description check Passed The description follows the repository template, explains the rationale, lists all workflow changes, documents compatibility details, records testing, and includes additional notes.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (3 skipped: 3 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant