Add new product for Ubuntu 26.04 and a default profile#14721
Conversation
WolfAnto
requested review from
a team,
Mab879,
ggbecker,
jan-cerny,
marcusburghardt and
vojtapolasek
as code owners
|
Hi @WolfAnto. Thanks for your PR. I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
This datastream diff is auto generated by the check Click here to see the full diffOVAL for rule 'xccdf_org.ssgproject.content_rule_installed_OS_is_vendor_supported' differs.
--- oval:ssg-installed_OS_is_vendor_supported:def:1
+++ oval:ssg-installed_OS_is_vendor_supported:def:1
@@ -14,3 +14,4 @@
extend_definition oval:ssg-installed_OS_is_slmicro6:def:1
extend_definition oval:ssg-installed_OS_is_ubuntu2204:def:1
extend_definition oval:ssg-installed_OS_is_ubuntu2404:def:1
+extend_definition oval:ssg-installed_OS_is_ubuntu2604:def:1 |
mpurg
added
Ubuntu
|
/ok-to-test |
openshift-ci
Bot
added
ok-to-test
mpurg
left a comment
mpurg
left a comment
There was a problem hiding this comment.
Thanks for contributing, looks good to me!
|
@WolfAnto: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| run: ssh-keygen -N '' -t rsa -f ~/.ssh/id_rsa | ||
| - name: Build test suite container | ||
| if: ${{ steps.ctf.outputs.CTF_OUTPUT_SIZE != '0' }} | ||
| run: podman build --build-arg "CLIENT_PUBLIC_KEY=$(cat ~/.ssh/id_rsa.pub)" -t ssg_test_suite -f test_suite-ubuntu2604 |
There was a problem hiding this comment.
The test_suite-ubuntu2604 Dockerfile doesn't exist.
| /controls/cis_sle15.yml @ComplianceAsCode/suse-maintainers | ||
| /controls/stig_slemicro5.yml @ComplianceAsCode/suse-maintainers | ||
| /controls/cis_ubuntu2404.yml @ComplianceAsCode/ubuntu-maintainers | ||
| /controls/cis_ubuntu2604.yml @ComplianceAsCode/ubuntu-maintainers No newline at end of file |
There was a problem hiding this comment.
This file doesn't exist.
|
@WolfAnto Please fix the references to non-existent files by either removing the references or adding the referenced files to the PR. |
The file does not yet exist and does not belong in CODEOWNERS
|
@jan-cerny Okay, it's been removed from the CODEOWNERS file. |
|
I can see that the reference to the non-existent control files has been removed from CODEOWNERS. But, the reference to the non-existent Dockerfile is still present in the .github/workflows/automatus-ubuntu2604.yml. |
|
Sorry, I forgot to create it, but it's done now. 60adb94 Everything should be fine now @jan-cerny |
Co-authored-by: Jan Černý <jcerny@redhat.com>
|
@jan-cerny |
|
@WolfAnto Thanks for the update. The "Build, Test" job has run and completed successfully. But, the "Automatus Ubuntu 26.04" job failed on the Dockerfile. It seems that the Dockerfile in this PR is misplaced - it's in the different directory than the configuration expects. Can you fix this? |
|
@jan-cerny that was a slip-up on my part when I created the file. I've moved it to the right place. |
Co-authored-by: Jan Černý <jcerny@redhat.com>
|
@jan-cerny ok, good |
jan-cerny
added
the
Highlight
3 participants
Description
I haven’t implemented the CIS profiles yet, because Ubuntu 26.04 was just released and the CIS hasn’t published a benchmark for creating one yet.
This pull request should therefore be seen as preparation for future CIS profiles or the STIG profile, while also giving some users the ability to create their own custom profiles.