Skip to content

Maintain dependencies and workspace lint coverage - #1163

Merged
GiggleLiu merged 5 commits into
mainfrom
chore/update-dependency-versions
Sep 18, 2026
Merged

GiggleLiu merged 5 commits into
mainfrom
chore/update-dependency-versions

Conversation

@isPANN

@isPANN isPANN commented Sep 17, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Update dependency minimum versions, including rmcp 3.4.0 and syn 3.0.6, with internal MCP and macro adaptations.
  • Remove unused ordered-float and direct CLI tracing dependencies; narrow Tokio to rt-multi-thread.
  • Exercise MCP tools, prompts, and errors over stdio.
  • Run CI and make clippy across every workspace crate, target, and feature.
  • Enforce the 95% coverage target without a tolerance allowance and clarify the final hung-test timeout.
  • Preserve public solver/reduction APIs and mathematical semantics; 12 files, based on main.

Verification

  • Integrated with all extracted safe-change branches: 6,572 workspace all-feature tests passed, 2 ignored.
  • Combined changed-line Rust coverage: 99.64%.
  • Workspace all-target all-feature Clippy, formatting, and whitespace checks pass.

@codecov

codecov Bot commented Sep 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.93%. Comparing base (7dd5fcd) to head (95c9315).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1163   +/-   ##
=======================================
  Coverage   95.93%   95.93%           
=======================================
  Files        1074     1074           
  Lines      132106   132106           
=======================================
  Hits       126730   126730           
  Misses       5376     5376           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@isPANN isPANN changed the title Update dependencies and adapt to rmcp 3 and syn 3 Update dependencies and lint all workspace features Sep 17, 2026
@isPANN isPANN changed the title Update dependencies and lint all workspace features Maintain dependencies and workspace lint coverage Sep 17, 2026
@GiggleLiu

Copy link
Copy Markdown
Contributor

Follow-up items (recorded during final review):

  • The MCP stdio integration tests (problemreductions-cli/tests/mcp_integration.rs) are gated on the mcp feature, and the CI test job runs with FEATURES=example-db, so CI only compiles them (via the new --all-features clippy) but never runs them. Consider adding make mcp-test to CI.

@GiggleLiu GiggleLiu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final review: make check and make mcp-test pass locally on the merged state (main re-merged after #1155/#1156). Approving.

@GiggleLiu
GiggleLiu merged commit d7077d7 into main Sep 18, 2026
9 checks passed
@isPANN
isPANN deleted the chore/update-dependency-versions branch September 18, 2026 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants