Skip to content

Fix negative weights in vertex cover to AND/OR graph reduction - #1160

Closed
isPANN wants to merge 1 commit into
mainfrom
fix/vertex-cover-and-or-negative-weights
Closed

isPANN wants to merge 1 commit into
mainfrom
fix/vertex-cover-and-or-negative-weights

Conversation

@isPANN

@isPANN isPANN commented Sep 17, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Include every negative-weight vertex in the recovered cover, even if isolated or redundant.
  • Reduce only edges not already covered by these forced vertices, using nonnegative residual weights.
  • Report target size formulas as upper bounds and document the residual optimum and constant objective offset.
  • Preserve the existing witness extraction API. Three files, based directly on main.

Verification

  • Regression test fails on main because recovered covers are not optimal.
  • Exhaustive source/target checks cover isolated negative vertices, adjacent negative vertices, mixed signs, and self-loops.
  • Full workspace all-feature tests: 6,479 passed; 2 existing ignored.
  • Focused reduction tests: 5 passed; changed-line coverage 100% across 29 lines.
  • Formatting, diff whitespace checks, workspace all-target all-feature Clippy with warnings denied, and make paper passed.

@codecov

codecov Bot commented Sep 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.93%. Comparing base (7dd5fcd) to head (b8a5765).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1160   +/-   ##
=======================================
  Coverage   95.93%   95.93%           
=======================================
  Files        1074     1074           
  Lines      132106   132130   +24     
=======================================
+ Hits       126730   126754   +24     
  Misses       5376     5376           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@isPANN

isPANN commented Sep 17, 2026

Copy link
Copy Markdown
Collaborator Author

Consolidated into #1155 for one review of combinatorial reduction correctness fixes. No changes have been merged to main.

@isPANN isPANN closed this Sep 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant