Birmingham | ITP-May-26 | Maryam Janjua | Sprint 4 | Project TV Show - #99
Open
maryam-devio wants to merge 12 commits into
Open
Birmingham | ITP-May-26 | Maryam Janjua | Sprint 4 | Project TV Show#99maryam-devio wants to merge 12 commits into
maryam-devio wants to merge 12 commits into
Conversation
West-Midlands | ITP-May-26 | Gabreil Pawuoi | Sprint 4 | Project TV Show
West-Midlands | ITP-May-26 | KhotKeys |Sprint 4 | Level 400; Shows dropdown with Cached Fetching
maryam-devio
added
📅 Sprint 4
LonMcGregor
reviewed
Sep 2, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
Contributor
There was a problem hiding this comment.
- good use of caching
- The deployed site meets all the functional requirements
- Missing good use of semantic HTML
Good work on this. ITP is complete now, but if you want an extra challenge, feel free to respond to my comments.
| <!-- Loads a provided function called getAllEpisodes() which returns all episodes --> | ||
| <script src="episodes.js"></script> | ||
|
|
||
| <!-- Loads YOUR javascript code --> |
Contributor
There was a problem hiding this comment.
Do you think there is a benefit to defining all the HTML in js rather than in the HTML file?
| card.appendChild(runtime); | ||
|
|
||
| const summary = document.createElement("div"); | ||
| summary.innerHTML = show.summary || ""; |
Contributor
There was a problem hiding this comment.
Compare this to how you handle the other details for shows - text vs HTML. which do you think is the better approach?
| if (show.image && show.image.medium) { | ||
| const img = document.createElement("img"); | ||
| img.src = show.image.medium; | ||
| img.alt = show.name; |
Contributor
There was a problem hiding this comment.
Is this an appropriate use of an alt tag? See what https://axesslab.com/alt-texts/ has to say
| searchInput.addEventListener("input", handleShowSearch); | ||
| showsView.appendChild(searchInput); | ||
|
|
||
| const showSelector = document.createElement("select"); |
Contributor
There was a problem hiding this comment.
Did you check if the lighthouse tool offers any advice for creating a select this way?
LonMcGregor
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
• Built through levels 0-500. Static episode display, live search, episode
selector, replaced static data with fetch calls to the TVMaze API, added
a shows dropdown with cached fetching, and a shows listing home page with
show search, genres, status, rating, and runtime. Deployed to Netlify at:
https://final-project-tv-show.netlify.app/
• Partnered with Gabriel Pawuoi (KhotKeys) for levels 200 and 400.