Added literal prefix and suffix to getTypeInfo() to be close to v1#2884
Merged
Conversation
|
Repository collaborators can run the JMH benchmark suite against this PR by commenting: Optional regression threshold override (Δ% on Time or Alloc/op; defaults to 10%): Only one benchmark run per PR is active at a time — issuing a new |
Client V2 CoverageCoverage Report
Class Coverage
|
JDBC V2 CoverageCoverage Report
Class Coverage
|
JDBC V1 CoverageCoverage Report
Class Coverage
|
Client V1 CoverageCoverage Report
Class Coverage
|
TriageCategory: Summary What this impacts
Concerns
Required reviewer action
|
chernser
changed the title
There was a problem hiding this comment.
Pull request overview
This PR updates the jdbc-v2 DatabaseMetaData.getTypeInfo() implementation to populate the LITERAL_PREFIX and LITERAL_SUFFIX columns for ClickHouse types (closer to the v1 driver), and adds integration test assertions to prevent regressions.
Changes:
- Add a type-name → literal delimiter mapping and apply it as a
DetachedResultSetmutator ingetTypeInfo(). - Extend
DatabaseMetaDataTest#testGetTypeInfoto assert expected literal prefix/suffix perClickHouseDataType.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
jdbc-v2/src/main/java/com/clickhouse/jdbc/metadata/DatabaseMetaDataImpl.java |
Adds literal prefix/suffix mapping and mutator for getTypeInfo() rows. |
jdbc-v2/src/test/java/com/clickhouse/jdbc/metadata/DatabaseMetaDataTest.java |
Adds assertions for LITERAL_PREFIX/LITERAL_SUFFIX in getTypeInfo() integration test. |
|
mshustov
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LITERAL_PREFIXandLITERAL_SUFFIXproper values inDataBaseMetadata#getTypeInforesult set. Previously information was all nullAfter the change type info looks like (nulls because no string literal should be used) :
Closes: #2743
Checklist
Delete items not relevant to your PR:
Note
Low Risk
Metadata-only change to getTypeInfo() result shaping; no query execution or connection behavior changes. Wrong literals could mislead BI/SQL generators but scope is limited to JDBC metadata consumers.
Overview
DatabaseMetaData#getTypeInfo()now fillsLITERAL_PREFIXandLITERAL_SUFFIXper type instead of leaving them always null, aligning JDBC v2 with v1 behavior for tools that build SQL literals from type metadata.A static
TYPE_LITERAL_INFO_MAP(GuavaImmutableMap) maps ClickHouse type names—and many SQL-style aliases—to quote ('), bracket ([]), brace ({}), or parenthesis delimiters. A new row mutatorTYPE_INFO_LITERAL_FUNCTIONruns with the existinggetTypeInfopost-processors to set those columns when a type is known; numeric and similar types stay null.testGetTypeInfogainsTYPE_LITERAL_EXPECTATIONSand asserts prefix/suffix perClickHouseDataTypeso regressions are caught in integration tests.Reviewed by Cursor Bugbot for commit 7156c2e. Bugbot is set up for automated code reviews on this repo. Configure here.