Repository navigation
Website: fix the hardware page not loading with a stored theme - #2516
Merged
Merged
Conversation
When the theme was saved in localStorage, setTheme() called render() at load, before 'let pending_details' was initialized, throwing a ReferenceError and leaving the page empty. Apply the stored theme without rendering, as the main page does; the initial render runs at the end anyway. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the theme is stored in localStorage (e.g. after choosing the dark theme), the hardware page failed to load with
ReferenceError: Cannot access 'pending_details' before initialization:setTheme()calledrender()before thelet pending_detailsdeclaration (introduced in ac177c8 "Website: make switching selectors fast").Apply the stored theme without rendering, as the main page already does; the initial render runs at the end of the script.
Verified in headless Chromium with a stored dark theme: hardware, main, versions and gravitons pages all render, and theme toggling works.
🤖 Generated with Claude Code