issue#109: optional per-device config diff in the backup email by TheWitness · Pull Request #200 · Cacti/plugin_routerconfigs

TheWitness · 2026-11-11T23:27:14Z

Description

Final PR in the stacked chain (#133 → #117 → #130 → #109), built on top of the #130 branch. It optionally appends a per-device unified configuration diff to the backup Email so a reviewer can see exactly what changed on each device after a run.

A new Include Config Diffs setting enables the feature (off by default). When on, the backup Email gains a Configuration Changes section with a unified diff for each device whose configuration changed between its two most recent backups. When nothing changed, it says so explicitly.
A Diff Exclude Patterns setting takes regular expressions (one per line) matching volatile lines to ignore when comparing — e.g. timestamps or serial numbers — so those don't show up as spurious changes. Malformed patterns are ignored rather than fatal.
Binary (non-text) configurations are skipped (NUL-byte detection), as suggested in the issue discussion.
The existing Config Diff Context Lines setting (from add a setting for the config diff to show more lines before and after the config difference #195) controls the surrounding context, and the diff reuses Cacti core's jfcherng/php-diff (Horde Text_Diff fallback on 1.2.29-1.2.31, as on the Compare page).
When the Thold plugin is installed, a new Thold Notification List option can also send the Email to that list's recipients (the option only appears when Thold's notification-list table exists).

Backup-file reads are path-validated (the same containment check the Compare page uses) so a crafted directory/filename cannot escape the backup directory.

Related Issue

#109

Motivation and Context

Operators asked (in 2019, and again in 2023) for a daily emailed diff of each device's configuration, with the ability to exclude lines that always change (timestamps, serials) and to avoid diffing binary blobs — exactly the concerns raised in the issue thread. This builds that on top of the existing nightly summary Email and diff tooling.

How Has This Been Tested?

Ran the plugin's Pest suite from a Cacti checkout with the plugin as a real plugins/routerconfigs directory (the stacked diff covers #133 + #117 + #130 + #109):

Full suite: pest --configuration phpunit.xml → 190 passed (1145 assertions). Added tests/Unit/RouterconfigsDiffEmailTest.php covering text/binary detection, exclude-pattern parsing and line filtering (including a malformed pattern and a clamped diff context), unified-diff rendering (identical vs changed), safe backup-file reading (missing keys, traversal, and a symlink that escapes its directory), the two-most-recent-backups diff (changed / fewer-than-two / binary / unreadable), and the recipient resolution with and without a Thold list.
Patch coverage gate: php tests/bin/patch-coverage.php coverage/clover.xml origin/develop 100 → 100.00% (288/288 lines).
i18n gate: php tests/bin/check-i18n-pot.php origin/develop → OK (locales/po/cacti.pot regenerated; per-language .po/.mo left to Weblate).
PHP syntax: php -l clean on every changed file.
Manifest: php tests/bin/validate-manifest.php → matches.

The Email-assembly code that stitches the diffs into the message lives inside plugin_routerconfigs_download()'s existing @codeCoverageIgnore region (it needs a live poller run); the pure helpers it calls are all unit-tested. The Horde Text_Diff fallback is coverage-ignored because the CI Cacti (1.2.32+) always provides jfcherng, so that branch is unreachable there.

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.

somethingwithproof

Blocker: the Thold recipient list setting never appears. The code checks for plugin_thold_notification_lists, but Thold creates plugin_notification_lists (see includes/database.php in plugin_thold). db_table_exists() is always false, so the setting never renders and plugin_routerconfigs_notification_recipients() never adds the list's addresses. This option also isn't part of #109; it would be easier to review in its own PR, or at least listed in the description.

Suggestion: emailed diffs will carry secrets. A changed enable secret, snmp-server community, TACACS/RADIUS key, user password hash or crypto key all show up in the diff. The diff then goes to everyone on the email, including a notification list. The feature is off by default, but the setting's description should warn about this, and lines matching password, secret, community or key should be redacted by default (for example with built-in exclude patterns, or by masking the value).

Nit: plugin_routerconfigs_diff_exclude_lines() escapes / with str_replace(), so a pattern that already contains \/ becomes \\/ and is silently dropped as invalid. Also, the setting description says patterns are matched "against whole lines", but they aren't anchored, so they match any part of a line.

Nit: the db_table_exists() check at the top level of arrays.php runs a query every time the file is included.

SonarCloud duplicated-lines failure (5.4%): all 28 lines are in tests/Unit/RouterconfigsDiffEmailTest.php. The two-backups test and the binary-backup test repeat the same setup: temp directory, new.cfg/old.cfg contents and the db_fetch_assoc_prepared override. Moving that setup into one helper should clear the gate. For example:

function rc_diff_backups(string $new, string $old): string {
	$dir = sys_get_temp_dir() . '/rc-diff-' . uniqid();
	mkdir($dir, 0777, true);
	file_put_contents($dir . '/new.cfg', $new);
	file_put_contents($dir . '/old.cfg', $old);

	$GLOBALS['__stub_overrides']['db_fetch_assoc_prepared'] = fn ($sql, $params) => [
		['directory' => $dir, 'filename' => 'new.cfg'],
		['directory' => $dir, 'filename' => 'old.cfg'],
	];

	return $dir;
}

The cleanup (unlink/rmdir) could move into an afterEach(), which would also remove the leftover temp files when an assertion fails partway through.

…Email tests Moves the repeated temp directory, backup file and db_fetch_assoc_prepared stub setup into two helpers, and removes temp directories in afterEach() so a failed assertion no longer leaves them behind. Clears the SonarCloud duplicated-lines gate on this PR. Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>

somethingwithproof · 2026-11-12T00:54:44Z

Pushed 3b09ff6 to clear the SonarCloud duplicated-lines gate. It only touches tests/Unit/RouterconfigsDiffEmailTest.php:

rc_diff_tmpdir() and rc_diff_stub_backups() replace the repeated temp-directory, backup-file and db_fetch_assoc_prepared setup.
An afterEach() now removes the temp directories, so a failed assertion no longer leaves them behind.

The test cases and assertions are unchanged. SonarCloud passes on this head. The plugin CI only runs for PRs targeting develop/main, so I ran it locally the same way CI does (plugin harness Pest against a Cacti 1.2.x checkout): 11 passed in this file and 189 passed (1141 assertions) in the full suite, with no temp directories left over.

The review points above still stand.

…sue-109-diff-email Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>

…in emailed diffs The Thold Notification List option checked for plugin_thold_notification_lists, but Thold creates plugin_notification_lists (with an emails column, see plugin_thold includes/database.php). The table never existed, so the option never appeared and its addresses were never added. The setting, recipient lookup and tests now use plugin_notification_lists. The table check also ran at the top level of includes/arrays.php, a query on every include. routerconfigs_config_settings() now adds the option when it builds the Settings tab, with the same condition. Secret values in the emailed diff are now hidden by default: passwords and secrets of every type (0, 5, 7, 8, 9), SNMP communities and SNMPv3 auth/priv keys, TACACS+/RADIUS keys, ISAKMP/IKEv2 pre-shared keys, OSPF, BGP, HSRP, VRRP and IS-IS authentication, PPP and wireless keys, and certificate or key hex rows, following the line classes Oxidized's IOS and NX-OS models redact. A generic fallback hides the value after a password, secret, community or key keyword, so an unrecognized line fails closed. The diff is redacted rather than the configurations, so a changed secret still appears as a -/+ pair without either value. Coverage is Cisco-centric, which the setting description says. Sending secrets needs the new 'Include Secrets in Diffs' option, which is off by default and also off when unset, and the 'Include Config Diffs' description warns that the diff goes out in clear text. Lines that change on every backup are always left out of the comparison: '! Last configuration change', '! NVRAM config last updated', 'ntp clock-period' and 'Current configuration :' (Oxidized IOS model), and NX-OS '!Time:' and '!Running configuration last done at:'. Exclude patterns are compiled by plugin_routerconfigs_regex() from #130, so a pattern containing '\/' is no longer double escaped and dropped. The description now says patterns match anywhere in a line unless anchored with ^ or $. Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>

Review found the redaction fail-open in four ways: it hid only the first token of a value, so 'snmp-server community my secret RO' leaked the rest; it matched keywords only as whole words, missing tokens such as wpa-psk or set passwd; it handled each line alone, so multi-line secrets went out; and a keyword line in an unknown shape passed through. plugin_routerconfigs_redact_lines() now replaces everything after the first token containing passw, secret, psk, key, passphrase, community or md5 (plus an optional type number or ENC), keeping the line and anything after a quoted value that closes on the same line. It hides every line of a PEM block, a Cisco certificate or key-string block up to 'quit', and a quoted value continued on later lines, and hides any row of hex words or long base64 run on its own, so a block that starts outside a diff hunk is still covered. Keyword-less secrets (SNMP trap host communities, SNMPv3 keys, HSRP/VRRP text authentication) keep their own patterns. Each diff hunk is redacted as one sequence. This over-redacts some harmless lines, such as 'description key account'; the tests record that as accepted, and the setting description says redaction fails closed. Test values are placeholders. Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>

Hiding secrets in the diff output could not work reliably: a hunk can start in the middle of a certificate or quoted key, and the old and new sides shared one block state. Each full configuration is now redacted from its first line before the exclude patterns and the comparison run, so blocks are always tracked from where they open and context lines are already clean. A change confined to a hidden value no longer shows up. The per-configuration redactor also: - re-checks the rest of a line after a block closes, and checks block opener lines like any other line - opens Cisco certificate blocks only on 'certificate [ca|self-signed] <serial>' and bare 'key-string', and hides every line until 'quit', -----END or the closing quote, hiding to the end of the configuration when the block never ends - ends the kept part at the keyword word and an optional '=' or ':', so password=..., secret:... and key-string=... are hidden, and adds pwd; a type number or ENC stays only as a separate word - skips backslash-escaped quotes when looking for a closing quote - hides text authentication values in general (NHRP, bare 'authentication text'), leaving aaa method lists and the IOS 802.1X interface commands alone - lets a PEM marker that comes before a keyword win, so the kept part never includes a PEM body The tests run a realistic sample configuration through the redactor and the emailed diff, and check that no placeholder value is left on the old side, the new side or in the context lines. Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>

…g values Diffing the redacted configurations hid real changes: a changed password, or a crafted unterminated quote, redacted to the same text on both sides, so no hunk and no notice. And every value-parsing rule so far had a syntax that slipped past it. The comparison now runs on the raw lines (after the volatile and exclude filters), so every real change gives a hunk. Each whole configuration is redacted once from its first line, aligned with the raw lines, and the hunks print the redacted form of each line. A replaced line whose redacted form is unchanged is marked '(changed)', so a password change shows up as '-username <secret hidden>' and '+username <secret hidden> (changed)'. The hunks are rendered from jfcherng's grouped opcodes, or from Horde's edits grouped the same way on older Cacti releases. Redaction no longer parses values. A line that contains a secret-like word anywhere (passw, passphrase, pwd, secret, psk, key, community, md5, authentication, credential, token, private), a -----BEGIN marker or the start of a quoted value, and any snmp-server host or user line, is reduced to its indentation and leading word. Every line of a PEM block, a certificate block under 'crypto pki (or ca) certificate chain', a bare key-string block under 'crypto key pubkey-chain', or a quoted value left open by an odd number of unescaped quotes is hidden until it closes. A block that never closes hides the rest of the configuration, and the Email gets a note saying on which line it opened. Harmless lines that mention a key are hidden too, which is accepted and described in the setting. The tests cover every earlier bypass (key=value, key:value, JSON pairs, quoted keywords, escaped and unterminated quotes, values with spaces, standby/vrrp/nhrp/ospf authentication, certificate, key-string and PEM blocks, a hunk that starts mid-block) through the emailed diff, a diff without secrets, the unclosed-block note on either side, Horde grouping against jfcherng's, and a realistic configuration with no placeholder left anywhere. Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>

…sue-109-diff-email locales/po/cacti.pot regenerated. Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>

…ines With the comparison on the raw lines, hiding too much can no longer hide a change, so redaction errs fully toward hiding: - certificate and key-string blocks open wherever those lines appear, not only under their usual parent - a hex or base64 row is hidden even outside a block - single-quoted multi-line values are tracked like double-quoted ones - the state after each line is worked out from the whole line, so a line that closes one block and opens another (-----END X----- -----BEGIN Y-----, or a closing double quote followed by an opening single quote) keeps the next block hidden, and a terminator line is shown only when it is a bare quit or -----END line that leaves no block open The note for a block that never closes is kept. Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>

@somethingwithproof

Resolved by @somethingwithproof

somethingwithproof · 2026-11-12T02:00:07Z

Pushed for the review, after merging #199 (1529385, 1d42339):

d77483e: the Thold list now reads plugin_notification_lists/emails, and the setting is added in routerconfigs_config_settings, so arrays.php no longer queries on every include. Volatile IOS and NX-OS lines are always ignored. Exclude patterns go through plugin_routerconfigs_regex(), so \/ survives, and the description now says patterns match anywhere unless anchored. Diff secrets are hidden by default; a new opt-in 'Include Secrets in Diffs' setting turns that off, and the description warns that diffs go out in clear text.
badc0e5, 60f47bc, ff84b65, 86046b0: redaction was reworked after security review. Hiding secrets in the diff output failed open in several ways: hunks that start mid-block, old and new sides sharing block state, and value syntaxes the parsers missed. It now works like this:
- The diff is computed on the raw lines, after the volatile and exclude filters, so every real change gives a hunk.
- Each whole configuration is redacted once from line 1, and the hunks print the redacted form of each line. A changed password shows as -username <secret hidden> / +username <secret hidden> (changed).
- Values are not parsed. A line containing a secret-like word anywhere (passw, passphrase, pwd, secret, psk, key, community, md5, authentication, credential, token, private), and any snmp-server host or user line, is reduced to its leading word.
- Every line of a PEM block, a certificate or key-string block, a multi-line single- or double-quoted value, and any hex or base64 row, is hidden. The state after each line is worked out from the whole line.
- A block that never closes hides the rest of the configuration and adds a note to the Email.
- The hunks render from jfcherng's grouped opcodes, or from Horde's edits, grouped the same way, on Cacti before 1.2.32.

Tests: every earlier bypass (key=value, key:value, JSON, quoted keywords, escaped and unterminated quotes, spaced values, standby/vrrp/nhrp/ospf authentication, cert, key-string and PEM blocks, a hunk that starts mid-block, blocks closing and reopening on one line) runs through the emailed diff with placeholder values, asserting a hunk and no placeholder. Further tests cover a diff without secrets, the unclosed-block note on both sides, Horde grouping against jfcherng, and a realistic configuration with nothing left anywhere. 284 passed locally, and the new cases fail on the previous heads. SonarCloud and the PHP 8.2-8.6 integration jobs pass on 86046b0.

Profiling (median, 1% of lines changed, 20 exclude patterns):

config lines	`device_config_diff` redacted	secrets kept	jfcherng diff alone
5,000	25 ms	19 ms	8 ms
50,000	668 ms	603 ms	482 ms
200,000	11.4 s	10.8 s	9.9 s

The diff library dominates and grows faster than linear. Redaction is 3/30/121 ms. Running the excludes through preg_grep per pattern would be 2-3x faster for that step, but it saves about 4% overall and drops lines silently on a PCRE runtime error, so I left it. The Email does one SELECT ... LIMIT 2 and two file reads per passed device, so 5,000 queries at 5,000 devices, with no cap on the diff section's size.

To revisit:

Should the Email cap the number of device diffs or the total size? A large run can produce a very large message.
Redaction over-hides by design (e.g. description key account, aaa authentication ..., and a stray apostrophe opens a single-quote block). Changes still show, as hidden lines.
The Thold list's enabled column is ignored, as before.
The Thold option could still move to its own PR if you prefer.

…sue-109-diff-email Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>

Copilot

🟡 Changes recommended

Unresolved issues can expose SNMPv3 credentials in emails, send notifications from disabled lists, and skip delivery to Bcc-only recipients.

3 open issues

Redact credentials in SNMPv3 user lines · New
Skip disabled Thold notification lists · New
Include Bcc-only notification lists in backup email recipients · New

What changed in this PR

Adds optional per-device configuration diffs to RouterConfigs backup emails, building on the existing backup summary and diff tooling to address issue #109.

Changes:

Compares each device’s two latest backups, with volatile-line filtering, binary detection, configurable context, and default secret redaction.
Adds email-diff settings and optional Thold notification-list recipients.
Adds unit coverage and updates translation strings and the changelog.

File	Description
`tests/Unit/RouterconfigsDiffEmailTest.php`	Tests diff generation, redaction, file containment, and recipient resolution.
`tests/Unit/RouterconfigsConfigTest.php`	Tests conditional availability of the Thold setting.
`setup.php`	Registers the notification-list setting when Thold’s table exists.
`locales/po/cacti.pot`	Adds translation entries for settings and diff messages.
`includes/functions.php`	Implements email diffs, filtering, redaction, and recipient resolution.
`includes/arrays.php`	Defines diff and notification-list settings.
`CHANGELOG.md`	Records the configuration-diff email feature.

_{Review effort: Balanced}

…user rows Skip a notification list that is disabled, send its Bcc recipients through mailer(), and hide HPE 'snmpv3 user' lines in emailed diffs. Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>

TheWitness · 2026-11-13T15:00:38Z

Automated validity review of @somethingwithproof's commits on this PR

Reviewed and validated: full Pest suite passes (289 tests, 100% patch coverage), all integration legs (PHP 8.2–8.6) and SonarCloud are green, PHP lint clean, i18n/manifest gates pass, version correct (1.11). The fixes are solid — in particular correcting the Thold table name from the nonexistent plugin_thold_notification_lists to plugin_notification_lists (so the notification-list feature actually works), moving the table-existence check out of includes/arrays.php's top level into routerconfigs_config_settings(), and using mailer() for Bcc support.

Two notes for maintainer awareness (neither fails CI on this branch):

Stacking drift with Custom confirmation prompt acknowledgement at device login via SSH #130 — this branch is exactly one commit behind the head of the base PR Custom confirmation prompt acknowledgement at device login via SSH #130: commit 77c3526 ("answer Telnet post-login menus and send prompt responses with CR", which adds SendResponse() and the post-login-menu handling in PHPTelnet::Connect()) is not present here. So ProcessLoginPrompts() on this branch is still the older DoCommand() version with no parameter. Re-merge Custom confirmation prompt acknowledgement at device login via SSH #130 into this branch (or let it rebase after Custom confirmation prompt acknowledgement at device login via SSH #130 lands) so the final PR in the chain reflects the latest Custom confirmation prompt acknowledgement at device login via SSH #130 behavior.
Scope expansion (secret redaction) — this PR grew well beyond the original "diff email" request to include a substantial, security-sensitive secret-redaction engine for the emailed diffs. It's well-implemented (fail-closed; diffs run on raw lines so a changed secret still shows as a -/+ pair without values; redaction is opt-out via the off-by-default "Include Secrets in Diffs" setting). Worth a conscious maintainer sign-off given the heuristics are Cisco/NX-OS-centric (as the setting description states) and enabling "Include Config Diffs" sends configuration text by email.

TheWitness · 2026-11-13T16:00:27Z

Reconciliation done. Merged the head of #130 (77c3526) into this branch (merge commit e4b1ad2), so the stacking drift noted above is resolved — #130's tip is now an ancestor of #109, and ProcessLoginPrompts() here uses the newer SendResponse() (CR-terminated, untrimmed reply) plus the PHPTelnet::Connect() post-login-menu handling. No conflicts.

Validated after the merge: full Pest suite passes (291 tests, 100% patch coverage), PHP lint clean, i18n and manifest gates pass, DST-robust (America/New_York), version unchanged at 1.11. The #109 secret-redaction/diff code is intact alongside the merged #130 changes.

…e-109-diff-email # Conflicts: # locales/po/cacti.pot

sonarqubecloud · 2026-11-13T19:37:38Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

TheWitness · 2026-11-13T19:40:22Z

Conflicts resolved. The base branch (#130) advanced — #197 and #198 merged to develop, #130 merged develop in, and Weblate pushed translation updates — which left this PR conflicting on locales/po/cacti.pot.

Merged the current head of #130 into this branch (merge commit 3e5eca2). The only conflict was the cacti.pot POT-Creation-Date header; I regenerated cacti.pot from the merged source via xgettext so its string set is authoritative (the inherited per-language .po updates come from #130's Weblate commits, not authored here). All other files auto-merged.

GitHub now reports this PR as MERGEABLE. Validated after the merge:

Full Pest suite: 304 passed (1736 assertions), 100% patch coverage vs develop.
All integration legs (PHP 8.2–8.6) and SonarCloud: green.
PHP lint clean, i18n + manifest gates pass, DST-robust (America/New_York), version unchanged at 1.11.
Feature coexistence confirmed: DIff email #109 secret-redaction/diff code, Custom confirmation prompt acknowledgement at device login via SSH #130 SendResponse()/post-login-menu handling, and the New Features: TFTP ip, Schedule, Router edit and add features. #133/Scheduling Routerconfig Backup Weekly on a specific day or a date #117 scheduler work (now inherited via develop) all present together.

The remaining BLOCKED state is the normal stacked-PR gate (this PR can merge once its base #130 lands and it retargets to develop), not a conflict.

TheWitness force-pushed the feature/issue-109-diff-email branch from c1840f5 to 311a314 Compare November 11, 2026 23:49

issue#109:

72a5d43

TheWitness force-pushed the feature/issue-109-diff-email branch from 311a314 to 72a5d43 Compare November 11, 2026 23:57

somethingwithproof previously requested changes Nov 12, 2026

View reviewed changes

somethingwithproof added 6 commits November 11, 2026 17:23

Merge branch 'feature/issue-130-custom-login-prompts' into feature/is…

1529385

…sue-109-diff-email Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>

Merge branch 'feature/issue-130-custom-login-prompts' into feature/is…

1d42339

…sue-109-diff-email locales/po/cacti.pot regenerated. Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>

TheWitness added this pull request to stack #201 November 12, 2026 01:56

Copilot AI balanced review requested due to automatic review settings November 12, 2026 01:56

Copilot started reviewing on behalf of TheWitness November 12, 2026 01:57

View session

Merge branch 'feature/issue-130-custom-login-prompts' into feature/is…

c8b5b43

…sue-109-diff-email Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>

Copilot AI reviewed Nov 12, 2026

View reviewed changes

Comment thread includes/functions.php Resolved

Comment thread includes/functions.php Resolved

Comment thread includes/functions.php Resolved

xmacan previously approved these changes Nov 12, 2026

View reviewed changes

issue#109: honor a disabled or Bcc-only Thold list and redact snmpv3 …

aa5fa6c

…user rows Skip a notification list that is disabled, send its Bcc recipients through mailer(), and hide HPE 'snmpv3 user' lines in emailed diffs. Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>

somethingwithproof dismissed xmacan’s stale review via aa5fa6c November 12, 2026 07:45

somethingwithproof approved these changes Nov 12, 2026

View reviewed changes

somethingwithproof previously approved these changes Nov 12, 2026

View reviewed changes

xmacan previously approved these changes Nov 12, 2026

View reviewed changes

somethingwithproof added the enhancement label Nov 13, 2026

Merge

e4b1ad2

TheWitness dismissed stale reviews from xmacan and somethingwithproof via e4b1ad2 November 13, 2026 16:00

xmacan previously approved these changes Nov 13, 2026

View reviewed changes

Merge branch feature/issue-130-custom-login-prompts into feature/issu…

3e5eca2

…e-109-diff-email # Conflicts: # locales/po/cacti.pot

TheWitness dismissed xmacan’s stale review via 3e5eca2 November 13, 2026 19:36

xmacan approved these changes Nov 13, 2026

View reviewed changes

TheWitness merged commit d14827d into develop Nov 13, 2026
7 checks passed

TheWitness deleted the feature/issue-109-diff-email branch November 13, 2026 19:56

Navigation Menu

Repository navigation

issue#109: optional per-device config diff in the backup email - #200

issue#109: optional per-device config diff in the backup email#200
TheWitness merged 13 commits into
feature/issue-130-custom-login-promptsfrom
feature/issue-109-diff-email

TheWitness commented Nov 11, 2026

Uh oh!

somethingwithproof left a comment

Uh oh!

somethingwithproof commented Nov 12, 2026

Uh oh!

somethingwithproof commented Nov 12, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

TheWitness commented Nov 13, 2026

Uh oh!

TheWitness commented Nov 13, 2026

Uh oh!

sonarqubecloud Bot commented Nov 13, 2026

Uh oh!

TheWitness commented Nov 13, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

TheWitness commented Nov 11, 2026

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Types of changes

Checklist:

Uh oh!

somethingwithproof left a comment

Choose a reason for hiding this comment

Uh oh!

somethingwithproof commented Nov 12, 2026

Uh oh!

somethingwithproof commented Nov 12, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Uh oh!

TheWitness commented Nov 13, 2026

Uh oh!

TheWitness commented Nov 13, 2026

Uh oh!

sonarqubecloud Bot commented Nov 13, 2026

Quality Gate passed

Uh oh!

TheWitness commented Nov 13, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants