Skip to content

feat: introduce glTF 3D scene export and headless EGL rendering backend - #54

Open
Paramveersingh-S wants to merge 3 commits into
CERN:mainfrom
Paramveersingh-S:feat/headless-egl-gltf
Open

feat: introduce glTF 3D scene export and headless EGL rendering backend#54
Paramveersingh-S wants to merge 3 commits into
CERN:mainfrom
Paramveersingh-S:feat/headless-egl-gltf

Conversation

@Paramveersingh-S

Copy link
Copy Markdown
Contributor

Following up on your work adding OBJ exports and Wayland support, I thought it would be a step forward to add glTF support.
I mirrored how you built the wsgl_obj.c workstation to create wsgl_gltf.c, which serializes the scene tree to a JSON format.
Also, since we sometimes need to run these exports on backend CI servers without a display manager, I added a fallback Headless EGL initialization context. This means OpenPHIGS can now render and generate SVGs/PDFs/glTFs purely server-side without needing xvfb or an X11/Wayland display server!

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one should not be in the repo.

#define PWST_HCOPY_TRUE_PDF 8
#define PWST_HCOPY_TRUE_SVG 9
#define PWST_HCOPY_TRUE_OBJ 10
#define PWST_HCOPY_TRUE_GLTF 11

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This new workstation type should be documented. PR #52 comes with more extensive man pages for popwk/popen_ws where this should go

Comment thread fetch_checks.py Outdated
@@ -0,0 +1,16 @@
import urllib.request, json

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add license headers.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this file for?

Comment thread memory.md Outdated
@@ -0,0 +1,39 @@
# OpenPHIGS Bindings Refactor (PR #51) - Memory & Context

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be part of the repository ?

@Paramveersingh-S

Copy link
Copy Markdown
Contributor Author

Hi @schwicke,

My apologies for mistakenly pushing those extra files in the previous commit, I've gone ahead and cleaned up the branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants