fix(renderer): deferred path honors the render-target override#121
Merged
Conversation
…render-to-texture works for 3D apps begin_texture_mode's override was only consulted by the simple 2D end_frame; end_frame_with_scene — the path every 3D app actually runs — acquired the surface unconditionally and presented, so render-to-texture silently no-oped for 3D content since Q1: the frame went to the screen and the RT kept its initial contents. (Found by the editor's thumbnail work: even a bare magenta clear never reached the texture.) Now: when the override is armed, the deferred frame's final passes (post/compose chain + 2D overlay — all depth-less, so no attachment-size hazards) write the RT view, nothing is acquired or presented, and the screenshot branch defers to the next real frame. All intermediate passes are unchanged. Proven end-to-end: the editor renders model thumbnails into 128px targets via dedicated frames and draws them through drawTexturePro — the first successful RT sampling in the engine. Follow-up: a golden test for the RT round-trip in the native suite. Claude-Session: https://claude.ai/code/session_01PmL9WgNMkAgvpYSHEZga8K
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthrough
ChangesRender-target output handling
Estimated code review effort: 3 (Moderate) | ~20 minutes ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
proggeramlug
added a commit
that referenced
this pull request
Jul 17, 2026
test: live-GPU regression pin for the deferred RT override (#121)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The override set by
begin_texture_modewas only consulted by the simple 2Dend_frame—end_frame_with_scene(every 3D app) acquired and presented the surface unconditionally, so render-to-texture has silently no-oped for 3D content since Q1. Now the deferred frame's final passes write the RT view (all depth-less — no attachment-size hazards), nothing presents, and the screenshot branch defers to the next real frame.Proven live: the editor's model thumbnails render into 128px targets and draw through
drawTexturePro— screenshot-verified, the first successful RT sampling in the engine. Follow-up tracked: a native golden test for the RT round-trip.https://claude.ai/code/session_01PmL9WgNMkAgvpYSHEZga8K
Summary by CodeRabbit