Skip to content

EN-061: SSR fireflies are the indoor blizzard#115

Merged
proggeramlug merged 1 commit into
mainfrom
docs/en-061-ssr-blizzard
Jul 16, 2026
Merged

EN-061: SSR fireflies are the indoor blizzard#115
proggeramlug merged 1 commit into
mainfrom
docs/en-061-ssr-blizzard

Conversation

@proggeramlug

@proggeramlug proggeramlug commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Bisect-proven with f12-live: speckles survive SSGI/SSAO/shadows off, vanish with SSR off. Shooter ships SSR off (planar probe covers water; SSR measured invisible outdoors). Ticket carries the engine-side fix shape: roughness cutoff, firefly clamp, Hi-Z hit validation.

Summary by CodeRabbit

  • Documentation
    • Added a ticket documenting an interior sparkle/firefly rendering issue that occurs when screen-space reflections are enabled.
    • Included reproduction steps, affected scenarios, current mitigation, and reference screenshots.
    • Documented proposed rendering improvements to reduce artifacts, including roughness filtering, brightness clamping, and improved hit validation.

@proggeramlug
proggeramlug merged commit 61f1746 into main Jul 16, 2026
@proggeramlug
proggeramlug deleted the docs/en-061-ssr-blizzard branch July 16, 2026 18:16
@coderabbitai

coderabbitai Bot commented Jul 16, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: f22a1a3f-def1-4965-a15d-84e562f685b3

📥 Commits

Reviewing files that changed from the base of the PR and between 9998b33 and a98641d.

📒 Files selected for processing (1)
  • docs/tickets.md

📝 Walkthrough

Walkthrough

Added EN-061 to docs/tickets.md, documenting an SSR-enabled interior firefly artifact, its suspected Hi-Z and TSR interaction, reproduction guidance, screenshots, current mitigation, and required engine fixes.

Changes

SSR indoor fireflies

Layer / File(s) Summary
Document SSR artifact and fixes
docs/tickets.md
Adds EN-061 with observed behavior, reproduction steps, screenshot references, the attributed SSR/Hi-Z mechanism, and proposed roughness, luminance, and hit-validation fixes.

Estimated code review effort: 1 (Trivial) | ~2 minutes

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/en-061-ssr-blizzard

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant