Skip to content

docs: GI A/B verdict — HW is a subtle warm-bounce grade for 30% of the frame#112

Merged
proggeramlug merged 1 commit into
mainfrom
docs/gi-ab-verdict
Jul 16, 2026
Merged

docs: GI A/B verdict — HW is a subtle warm-bounce grade for 30% of the frame#112
proggeramlug merged 1 commit into
mainfrom
docs/gi-ab-verdict

Conversation

@proggeramlug

@proggeramlug proggeramlug commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Clouds-off, gate-verified captures (archived in the shooter's tools/.testout): both paths have correct sun shadows; HW GI adds a mildly warmer indirect term (house facade most visibly). A grade-level difference for 14.4-vs-20.3 fps → SW stays the default, BLOOM_HW_GI=1 opts in per box. Re-open for indoor scenes or stronger hardware.

Summary by CodeRabbit

  • Documentation
    • Updated the Lumen hardware-versus-software comparison with completed clouds-off test results.
    • Documented shadow quality, visual tone differences, measured frame rates, and screenshot archive locations.
    • Removed the previously unresolved testing note.

@proggeramlug
proggeramlug merged commit ec69e80 into main Jul 16, 2026
@proggeramlug
proggeramlug deleted the docs/gi-ab-verdict branch July 16, 2026 12:51
@coderabbitai

coderabbitai Bot commented Jul 16, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: a07c9995-9df5-48ca-a4ad-ca5fb27652ed

📥 Commits

Reviewing files that changed from the base of the PR and between ffb7d23 and 9d1523f.

📒 Files selected for processing (1)
  • docs/tickets.md

📝 Walkthrough

Walkthrough

The Lumen ticket documents a completed clouds-off hardware-versus-software A/B test, including shadow correctness, tonal differences, FPS measurements, capture archives, and the recommendation to keep software rendering as the default.

Changes

Lumen measurement documentation

Layer / File(s) Summary
Record clouds-off A/B results
docs/tickets.md
Replaces the unresolved test note with measured shadow behavior, tonal observations, 14.4 versus 20.3 FPS results, archived capture locations, and an “SW stays default; opt in per box” verdict.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/gi-ab-verdict

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant